Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 345983004: Drop [NotEnumerable] from various toString() operations

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Drop [NotEnumerable] from various toString() operations Web IDL does not support non-enumerable stringifiers: http://heycam.github.io/webidl/#es-stringifier It does support unforgeable stringifiers, but that doesn't affect enumerability, only configurability and writability. DOM 4 defines DOMTokenList's stringifier without any extended attributes: http://w3c.github.io/dom/#interface-domtokenlist URL defines URLUtils's (and URLUtilsReadOnly's) stringifier without any extended attributes: http://url.spec.whatwg.org/#urlutils And since it's defined as "stringifier attribute DOMString href;" adding [NotEnumerable] is ambigious and, depending on interpretation, incorrect, since the 'href' attribute should certainly be enumerable. Firefox Nightly has enumerable 'toString' properties on all of Selection, DOMTokenList and URLUtils. Given all of this, there also doesn't appear to be a strong reason to have WebKitCSSMatrix's 'toString' non-enumerable. Remaining stringifiers not affected by this patch: DOMException, Window and Location. DOMException is an exception, and thus can't have a stringifier according to Web IDL, and Window and Location are pretty much just special. BUG=306606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/css/WebKitCSSMatrix.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTokenList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/URLUtils.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/URLUtilsReadOnly.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Selection.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jens Widell
arv: please review, and/or suggest other reviewers. A preparation for supporting the stringifier keyword, although ...
6 years, 6 months ago (2014-06-23 11:43:35 UTC) #1
arv (Not doing code reviews)
On 2014/06/23 at 11:43:35, jl wrote: > arv: please review, and/or suggest other reviewers. > ...
6 years, 6 months ago (2014-06-23 15:49:10 UTC) #2
arv (Not doing code reviews)
6 years, 6 months ago (2014-06-23 15:51:00 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698