Expose toString() as enumerable on some objects.

Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=philipj@opera.com, jochen
BUG=306606
Committed: https://crrev.com/ca9d83f416cb0fc53e886c2bf308a167d3d12758
Cr-Commit-Position: refs/heads/master@{#388521}

[sof, 2016-04-20 09:41:19]

Description was changed from

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable].

R=
BUG=306606
==========

to

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=
BUG=306606
==========

[sof, 2016-04-20 09:47:29]

sigbjornf@opera.com changed reviewers:
+ mkwst@chromium.org, philipj@opera.com

[sof, 2016-04-20 09:47:30]

please take a look.

Time to align with spec and others, see associated bug and
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179

(A subset of the older https://codereview.chromium.org/345983004/ , not doing
all in one go.)

[philipj_slow, 2016-04-20 10:04:44]

The argument in https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179 was for
consistency with ES builtins. I don't about all of them, but at least
Object.prototype.propertyIsEnumerable('toString') returns false in Firefox and
Edge. However, Range.prototype.propertyIsEnumerable('toString') returns true in
both.

Can you comment on https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179 that
you're aligning Blink with the others and that all hope of consistency with ES
builtins is lost?

(If anyone thought it important, it might still be possible to turn everything
around and go with non-enumerable, but I'm not going to argue for that.)

[philipj_slow, 2016-04-20 10:07:32]

philipj@opera.com changed reviewers:
+ jochen@chromium.org

[philipj_slow, 2016-04-20 10:07:33]

LGTM, but it is a web-exposed change and the opposite direction was once
suggested, so adding Jochen for a second opinion.

[sof, 2016-04-20 10:55:02]

On 2016/04/20 10:04:44, philipj_slow wrote:
> The argument in https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179 was for
> consistency with ES builtins. I don't about all of them, but at least
> Object.prototype.propertyIsEnumerable('toString') returns false in Firefox and
> Edge. However, Range.prototype.propertyIsEnumerable('toString') returns true
in
> both.
> 

Range is spec'ed using "stringifier",
https://dom.spec.whatwg.org/#interface-range , so that makes sense. Blink
follows suit for Range.toString() enumerability, btw.

> Can you comment on https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179 that
> you're aligning Blink with the others and that all hope of consistency with ES
> builtins is lost?
> 

If this goes ahead, will do that.

> (If anyone thought it important, it might still be possible to turn everything
> around and go with non-enumerable, but I'm not going to argue for that.)

It appears not too important, but if that is deemed better for
http://heycam.github.io/webidl/#es-stringifier at some point, then Blink has to
re-align.

[jochen (gone - plz use gerrit), 2016-04-20 12:48:37]

lgtm

[sof, 2016-04-20 13:57:19]

Description was changed from

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=
BUG=306606
==========

to

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=philipj@opera.com, jochen
BUG=306606
==========

[sof, 2016-04-20 15:53:08]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-04-20 15:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1905553002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-04-20 15:53:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905553002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905553002/80001

[commit-bot: I haz the power, 2016-04-20 16:47:46]

Description was changed from

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=philipj@opera.com, jochen
BUG=306606
==========

to

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=philipj@opera.com, jochen
BUG=306606
==========

[commit-bot: I haz the power, 2016-04-20 16:47:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:24:23]

Description was changed from

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=philipj@opera.com, jochen
BUG=306606
==========

to

==========
Expose toString() as enumerable on some objects.

URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils
are required per spec to expose an enumerable toString() method.

Remove uses of [NotEnumerable] for these.

R=philipj@opera.com, jochen
BUG=306606

Committed: https://crrev.com/ca9d83f416cb0fc53e886c2bf308a167d3d12758
Cr-Commit-Position: refs/heads/master@{#388521}
==========

[commit-bot: I haz the power, 2016-04-22 19:24:24]

Patchset 5 (id:??) landed as
https://crrev.com/ca9d83f416cb0fc53e886c2bf308a167d3d12758
Cr-Commit-Position: refs/heads/master@{#388521}