Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1905383002: Retract SkDevice a bit more (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -41 lines) Patch
M gm/srcmode.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 4 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 5 chunks +17 lines, -17 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-22 15:48:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905383002/1
4 years, 8 months ago (2016-04-22 15:48:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 15:57:53 UTC) #8
reed1
lgtm
4 years, 8 months ago (2016-04-22 17:51:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905383002/1
4 years, 8 months ago (2016-04-22 17:56:24 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 17:57:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7715e06b68a1f07f07d23c63e7128d32654e30e9

Powered by Google App Engine
This is Rietveld 408576698