Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 1904723003: Revert of Use transfer buffer for BatchAtlas texture copies (Closed)

Created:
4 years, 8 months ago by jvanverth1
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use transfer buffer for BatchAtlas texture copies (patchset #9 id:160001 of https://codereview.chromium.org/1888473002/ ) Reason for revert: Lots of sync issues with paths and text. Original issue's description: > Use transfer buffer for BatchAtlas texture copies. > > Sets up use of transfer buffer (if available) to do one-copy transfers. > Get transfer buffers working properly in GL. > Implement GrVkGpu::onTransferPixels. > Check caps to ensure we can create a transfer buffer. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1888473002 > > Committed: https://skia.googlesource.com/skia/+/b0ec9836dbf7f2304a3a29289b818719ca0a39bd TBR=robertphillips@google.com,egdaniel@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c3d706f7ce87cdd94158d2266ab2fe2f18f5020a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -213 lines) Patch
M src/gpu/GrBatchAtlas.h View 4 chunks +5 lines, -12 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 9 chunks +24 lines, -55 lines 0 comments Download
M src/gpu/GrBatchFlushState.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/gpu/GrGpu.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLBuffer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +6 lines, -15 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +2 lines, -93 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jvanverth1
Created Revert of Use transfer buffer for BatchAtlas texture copies
4 years, 8 months ago (2016-04-20 17:33:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904723003/1
4 years, 8 months ago (2016-04-20 17:33:21 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 17:33:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c3d706f7ce87cdd94158d2266ab2fe2f18f5020a

Powered by Google App Engine
This is Rietveld 408576698