chrome/browser/android/offline_pages/offline_page_utils.cc - Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils.cc

Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests compilation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc ('k') | chrome/browser/android/offline_pages/offline_page_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils.cc b/chrome/browser/android/offline_pages/offline_page_utils.cc

index 4c8891b36f5ee2ee363c407ea8ce73d7494a0b93..8763619fe119f1105b90226407d144358a5a181a 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils.cc

@@ -104,7 +104,7 @@ int64_t OfflinePageUtils::GetBookmarkIdForOfflineURL(

if (!offline_page)

return -1;

- if (offline_page->client_id.name_space != offline_pages::BOOKMARK_NAMESPACE) {

+ if (offline_page->client_id.name_space != offline_pages::kBookmarkNamespace) {

return -1;

}