chrome/browser/android/offline_pages/offline_page_utils_unittest.cc - Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests compilation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/bookmarks/bookmark_model_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

index eba47c93aef7829c1877b7ef2e5c0155250c3ced..baf85f583e1f60d66f9558916c5b300322085036 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

@@ -135,7 +135,7 @@ void OfflinePageUtilsTest::CreateOfflinePages() {

std::unique_ptr<OfflinePageTestArchiver> archiver(BuildArchiver(

kTestPage1Url, base::FilePath(FILE_PATH_LITERAL("page1.mhtml"))));

offline_pages::ClientId client_id;

- client_id.name_space = BOOKMARK_NAMESPACE;

+ client_id.name_space = kBookmarkNamespace;

client_id.id = kTestPage1ClientId;

model->SavePage(

kTestPage1Url, client_id, std::move(archiver),

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/bookmarks/bookmark_model_factory.cc » ('j') | no next file with comments »