Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests compilation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
index 06444514709e5822ea572a554a534e0fca0336af..f84da3a7a8be8584563ff2d92c72bf5067c16b85 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
@@ -29,7 +29,7 @@ namespace offline_pages {
namespace {
const GURL kTestPageUrl("http://test.org/page1");
-const ClientId kTestPageBookmarkId = ClientId(BOOKMARK_NAMESPACE, "1234");
+const ClientId kTestClientId = ClientId(kBookmarkNamespace, "1234");
const int64_t kTestFileSize = 876543LL;
class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {
@@ -117,7 +117,7 @@ void OfflinePageTabHelperTest::SetUp() {
std::unique_ptr<OfflinePageTestArchiver> archiver(BuildArchiver(
kTestPageUrl, base::FilePath(FILE_PATH_LITERAL("page1.mhtml"))));
model->SavePage(
- kTestPageUrl, kTestPageBookmarkId, std::move(archiver),
+ kTestPageUrl, kTestClientId, std::move(archiver),
base::Bind(&OfflinePageTabHelperTest::OnSavePageDone, AsWeakPtr()));
RunUntilIdle();
}
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698