Chromium Code Reviews| Index: chrome/browser/ui/website_settings/permission_bubble_request.h |
| diff --git a/chrome/browser/ui/website_settings/permission_bubble_request.h b/chrome/browser/ui/website_settings/permission_bubble_request.h |
| index 50692c855115b70259f0aa61b53ec02796326b90..36862cd7886d232b36f32a30c901d3580b2d0211 100644 |
| --- a/chrome/browser/ui/website_settings/permission_bubble_request.h |
| +++ b/chrome/browser/ui/website_settings/permission_bubble_request.h |
| @@ -6,6 +6,7 @@ |
| #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_REQUEST_H_ |
| #include "base/strings/string16.h" |
| +#include "content/public/browser/permission_type.h" |
| #include "url/gurl.h" |
| namespace gfx { |
| @@ -22,11 +23,16 @@ enum class VectorIconId; |
| enum class PermissionBubbleType { |
| UNKNOWN, |
| MULTIPLE, |
| - PERMISSION, |
| + UNUSED_PERMISSION, |
| QUOTA, |
| DOWNLOAD, |
| MEDIA_STREAM, |
| REGISTER_PROTOCOL_HANDLER, |
| + PERMISSION_GEOLOCATION, |
|
felt
2016/04/27 15:37:24
nit: why are these (but not the others) prefixed w
benwells
2016/04/28 00:16:59
No big reason, just because they correspond to Per
|
| + PERMISSION_MIDI_SYSEX, |
| + PERMISSION_NOTIFICATIONS, |
| + PERMISSION_PROTECTED_MEDIA_IDENTIFIER, |
| + PERMISSION_PUSH_MESSAGING, |
| // NUM must be the last value in the enum. |
| NUM |
| }; |
| @@ -82,6 +88,7 @@ class PermissionBubbleRequest { |
| // eventually be called on every request which is not unregistered. |
| virtual void RequestFinished() = 0; |
| + // Used to record UMA metrics for bubbles. |
| virtual PermissionBubbleType GetPermissionBubbleType() const; |
| }; |