Log UMA metrics for permission type when permission bubbles shown.

chrome/browser/permissions/permission_bubble_request_impl.cc

Index: chrome/browser/permissions/permission_bubble_request_impl.cc
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc
index dfbe7c2ea5b440fe814073db22f8579f281e1c5e..a12305b0307914063aade9b0f2541199bea095ec 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.cc
+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc
@@ -166,5 +166,23 @@ void PermissionBubbleRequestImpl::RequestFinished() {
 
 PermissionBubbleType PermissionBubbleRequestImpl::GetPermissionBubbleType()
     const {
-  return PermissionBubbleType::PERMISSION;
+  switch (permission_type_) {
+    case content::PermissionType::GEOLOCATION:
+      return PermissionBubbleType::PERMISSION_GEOLOCATION;
+#if defined(ENABLE_NOTIFICATIONS)
+    case content::PermissionType::NOTIFICATIONS:
+      return PermissionBubbleType::PERMISSION_NOTIFICATIONS;
+#endif
+    case content::PermissionType::MIDI_SYSEX:
+      return PermissionBubbleType::PERMISSION_MIDI_SYSEX;
+    case content::PermissionType::PUSH_MESSAGING:
+      return PermissionBubbleType::PERMISSION_PUSH_MESSAGING;
+#if defined(OS_CHROMEOS)
+    case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER:
+      return PermissionBubbleType::PERMISSION_PROTECTED_MEDIA_IDENTIFIER;
+#endif
+    default:
+      NOTREACHED();
+      return PermissionBubbleType::UNKNOWN;

[felt, 2016/04/27 15:37:24]

weird to have a return after a NOTREACHED()?

[benwells, 2016/04/28 00:16:59]

To compile the function has to return something, plus NOTREACHED will be
compiled out on Release builds.

+  }
 }