Log UMA metrics for permission type when permission bubbles shown.

chrome/browser/ui/website_settings/permission_bubble_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_REQUEST_H_
 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_REQUEST_H_
 
 #include "base/strings/string16.h"
+#include "content/public/browser/permission_type.h"
 #include "url/gurl.h"
 
 namespace gfx {
 enum class VectorIconId;
 }
 
 // Used for UMA to record the types of permission prompts shown.
 // This corresponds to the PermissionBubbleType enum in
 // src/tools/metrics/histograms.xml. The usual rules of updating UMA values
 // applies to this enum:
 // - don't remove values
 // - only ever add values at the end
 // - keep the PermissionBubbleType enum in sync with this definition.
 enum class PermissionBubbleType {
   UNKNOWN,
   MULTIPLE,
-  PERMISSION,
+  UNUSED_PERMISSION,
   QUOTA,
   DOWNLOAD,
   MEDIA_STREAM,
   REGISTER_PROTOCOL_HANDLER,
+  PERMISSION_GEOLOCATION,

[felt, 2016/04/27 15:37:24]

nit: why are these (but not the others) prefixed with PERMISSION_ ?

[benwells, 2016/04/28 00:16:59]

No big reason, just because they correspond to PermissionType.

+  PERMISSION_MIDI_SYSEX,
+  PERMISSION_NOTIFICATIONS,
+  PERMISSION_PROTECTED_MEDIA_IDENTIFIER,
+  PERMISSION_PUSH_MESSAGING,
   // NUM must be the last value in the enum.
   NUM
 };
 
 // Describes the interface a feature utilizing permission bubbles should
 // implement. A class of this type is registered with the permission bubble
 // manager to receive updates about the result of the permissions request
 // from the bubble. It should live until it is unregistered or until
 // RequestFinished is called.
 // Note that no particular guarantees are made about what exact UI surface
@@ skipping 35 matching lines @@
   // corresponds to a denial, but is segregated in case the context needs to
   // be able to distinguish between an active refusal or an implicit refusal.
   virtual void Cancelled() = 0;
 
   // The bubble this request was associated with was answered by the user.
   // It is safe for the request to be deleted at this point -- it will receive
   // no further message from the permission bubble system. This method will
   // eventually be called on every request which is not unregistered.
   virtual void RequestFinished() = 0;
 
+  // Used to record UMA metrics for bubbles.
   virtual PermissionBubbleType GetPermissionBubbleType() const;
 };
 
 #endif  // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_REQUEST_H_