Log UMA metrics for permission type when permission bubbles shown.

chrome/browser/permissions/permission_bubble_request_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_bubble_request_impl.h"
 
 #include "build/build_config.h"
 #include "chrome/browser/permissions/permission_context_base.h"
 #include "chrome/browser/permissions/permission_uma_util.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 148 matching lines @@
   permission_decided_callback_.Run(false, CONTENT_SETTING_DEFAULT);
 }
 
 void PermissionBubbleRequestImpl::RequestFinished() {
   is_finished_ = true;
   delete_callback_.Run();
 }
 
 PermissionBubbleType PermissionBubbleRequestImpl::GetPermissionBubbleType()
     const {
-  return PermissionBubbleType::PERMISSION;
+  switch (permission_type_) {
+    case content::PermissionType::GEOLOCATION:
+      return PermissionBubbleType::PERMISSION_GEOLOCATION;
+#if defined(ENABLE_NOTIFICATIONS)
+    case content::PermissionType::NOTIFICATIONS:
+      return PermissionBubbleType::PERMISSION_NOTIFICATIONS;
+#endif
+    case content::PermissionType::MIDI_SYSEX:
+      return PermissionBubbleType::PERMISSION_MIDI_SYSEX;
+    case content::PermissionType::PUSH_MESSAGING:
+      return PermissionBubbleType::PERMISSION_PUSH_MESSAGING;
+#if defined(OS_CHROMEOS)
+    case content::PermissionType::PROTECTED_MEDIA_IDENTIFIER:
+      return PermissionBubbleType::PERMISSION_PROTECTED_MEDIA_IDENTIFIER;
+#endif
+    default:
+      NOTREACHED();
+      return PermissionBubbleType::UNKNOWN;

[felt, 2016/04/27 15:37:24]

weird to have a return after a NOTREACHED()?

[benwells, 2016/04/28 00:16:59]

To compile the function has to return something, plus NOTREACHED will be
compiled out on Release builds.

+  }
 }