Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1903103002: Remove some dead code for permission bubbles. (Closed)

Created:
4 years, 8 months ago by benwells
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, felt
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, posciak+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, Michael van Ouwerkerk, mlamouri+watch-permissions_chromium.org, markusheintz_, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dead code for permission bubbles. BUG=None Committed: https://crrev.com/760d037449d8a6a5b1e3820fc026447849a17876 Cr-Commit-Position: refs/heads/master@{#390305}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix rebase error #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -95 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 1 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/download/download_permission_request.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_permission_request.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 2 2 chunks +12 lines, -12 lines 2 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.cc View 1 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_request.h View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
benwells
4 years, 8 months ago (2016-04-21 00:08:17 UTC) #2
felt
nice cleanup! one question https://codereview.chromium.org/1903103002/diff/40001/chrome/browser/media/media_stream_devices_controller.cc File chrome/browser/media/media_stream_devices_controller.cc (right): https://codereview.chromium.org/1903103002/diff/40001/chrome/browser/media/media_stream_devices_controller.cc#newcode236 chrome/browser/media/media_stream_devices_controller.cc:236: base::string16 MediaStreamDevicesController::GetMessageText() const { why ...
4 years, 8 months ago (2016-04-21 13:57:08 UTC) #3
benwells
https://codereview.chromium.org/1903103002/diff/40001/chrome/browser/media/media_stream_devices_controller.cc File chrome/browser/media/media_stream_devices_controller.cc (right): https://codereview.chromium.org/1903103002/diff/40001/chrome/browser/media/media_stream_devices_controller.cc#newcode236 chrome/browser/media/media_stream_devices_controller.cc:236: base::string16 MediaStreamDevicesController::GetMessageText() const { On 2016/04/21 13:57:08, felt wrote: ...
4 years, 8 months ago (2016-04-21 23:47:57 UTC) #4
benwells
felt: friendly ping
4 years, 7 months ago (2016-04-27 12:08:23 UTC) #5
felt
whoops sorry i meant to lgtm the first time :)
4 years, 7 months ago (2016-04-27 15:30:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903103002/40001
4 years, 7 months ago (2016-04-27 21:57:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/174295)
4 years, 7 months ago (2016-04-27 22:06:50 UTC) #10
benwells
woops, forgot about the whole OWNERS thing... +thestig for owners review.
4 years, 7 months ago (2016-04-28 03:41:34 UTC) #11
benwells
actually +thestig this time, for owners review of chrome/ stuff
4 years, 7 months ago (2016-04-28 03:42:42 UTC) #13
Lei Zhang
lgtm
4 years, 7 months ago (2016-04-28 04:19:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903103002/40001
4 years, 7 months ago (2016-04-28 05:00:51 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 05:05:16 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:20 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/760d037449d8a6a5b1e3820fc026447849a17876
Cr-Commit-Position: refs/heads/master@{#390305}

Powered by Google App Engine
This is Rietveld 408576698