chrome/browser/permissions/permission_bubble_request_impl.h - Issue 1903103002: Remove some dead code for permission bubbles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 1903103002: Remove some dead code for permission bubbles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix rebase error Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_bubble_request_impl.h

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.h b/chrome/browser/permissions/permission_bubble_request_impl.h

index 75e2bf304ca9610a2c687ab111229e41ad1ff3e4..7eb40659bea282be3c102b8c9cf78cfbbdf07eba 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.h

+++ b/chrome/browser/permissions/permission_bubble_request_impl.h

@@ -37,7 +37,6 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

// PermissionBubbleRequest:

gfx::VectorIconId GetVectorIconId() const override;

int GetIconId() const override;

- base::string16 GetMessageText() const override;

base::string16 GetMessageTextFragment() const override;

GURL GetOrigin() const override;

// Remember to call RegisterActionTaken for these methods if you are