Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 1903103002: Remove some dead code for permission bubbles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase error Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc
diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
index e62eb4b5225d1072ce43c7e0b9d15baa8dee442c..d3d295157d85cfcbc828f7507d6ea0396ca48453 100644
--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
@@ -17,6 +17,7 @@
#include "base/gtest_prod_util.h"
#include "base/id_map.h"
#include "base/memory/ptr_util.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/waitable_event.h"
#include "base/test/simple_test_clock.h"
#include "base/time/clock.h"
@@ -391,7 +392,9 @@ base::string16 GeolocationPermissionContextTests::GetPromptText() {
#if !BUILDFLAG(ANDROID_JAVA_UI)
PermissionBubbleManager* manager =
PermissionBubbleManager::FromWebContents(web_contents());
- return manager->requests_.front()->GetMessageText();
+ PermissionBubbleRequest* request = manager->requests_.front();
+ return base::ASCIIToUTF16(request->GetOrigin().spec()) +
+ request->GetMessageTextFragment();
#else
infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
ConfirmInfoBarDelegate* infobar_delegate =

Powered by Google App Engine
This is Rietveld 408576698