Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902993002: [DevTools] Introduce provisional blackboxing (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce provisional blackboxing Two new protocol methods are introduced: Debugger.setBlackboxPatterns([patterns]) RegExp patterns can be installed via this method, this patterns is used to detect blackboxed scripts base on its sourceURL. Debugger.setScriptBlackboxed(url=,hash=,?ranges) Ranges can be setted by this method, this ranges is used to detect blackboxed call frames base on its script's location or url and position in source file. If ranges is omitted then whole script is blackboxed. Ranges is defined by array of source ranges { startLine, startColumn, endLine, endColumn }. BUG=563578 R=dgozman@chromium.org, pfeldman@chromium.org

Patch Set 1 #

Total comments: 14
Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -145 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setBlackboxPatterns.html View 1 chunk +67 lines, -0 lines 2 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setBlackboxPatterns-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setScriptBlackboxed.html View 1 chunk +20 lines, -0 lines 1 comment Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html View 2 chunks +22 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges-expected.txt View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js View 11 chunks +71 lines, -22 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +27 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 15 chunks +36 lines, -36 lines 3 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 3 chunks +16 lines, -5 lines 4 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 7 chunks +149 lines, -29 lines 2 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kozy
Please take a look.
4 years, 8 months ago (2016-04-19 21:46:25 UTC) #1
dgozman
https://codereview.chromium.org/1902993002/diff/1/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setBlackboxPatterns.html File third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setBlackboxPatterns.html (right): https://codereview.chromium.org/1902993002/diff/1/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setBlackboxPatterns.html#newcode38 third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setBlackboxPatterns.html:38: InspectorTest.sendCommand("Debugger.setBlackboxPatterns", { patterns: [ "foo([" ] }, dumpError); Let's ...
4 years, 8 months ago (2016-04-20 02:06:40 UTC) #2
dgozman
Are we going to continue this effort?
4 years, 5 months ago (2016-07-09 21:29:25 UTC) #3
kozy
4 years, 5 months ago (2016-07-10 04:18:50 UTC) #4 
On 2016/07/09 21:29:25, dgozman wrote:
> Are we going to continue this effort?

Yes, first part was landed separately. I'm going to upload second part during
next week.

Powered by Google App Engine
This is Rietveld 408576698