third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp - Issue 1902993002: [DevTools] Introduce provisional blackboxing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

Issue 1902993002: [DevTools] Introduce provisional blackboxing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

index 1829645fa5cf1b91dd524c99ed11e8696c8cc749..be7bef642cc143bb8456109f3d8ce856d9e5d12a 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

@@ -29,6 +29,10 @@ V8Regex::V8Regex(V8DebuggerImpl* debugger, const String16& pattern, bool caseSen

v8::Local<v8::RegExp> regex;

if (v8::RegExp::New(context, toV8String(isolate, pattern), static_cast<v8::RegExp::Flags>(flags)).ToLocal(&regex))

m_regex.Reset(isolate, regex);

+ else if (tryCatch.HasCaught())

+ m_errorMessage = toProtocolString(tryCatch.Message()->Get());

+ else

+ m_errorMessage = "Internal error";

}

int V8Regex::match(const String16& string, int startFrom, int* matchLength) const