Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 1902993002: [DevTools] Introduce provisional blackboxing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
index e261dd7a7bf8a47531b72326534ecc36b1cf0ae6..fc3de3cfaaea7756cd8284be0583a614985daf71 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
@@ -17,6 +17,7 @@ namespace blink {
class JavaScriptCallFrame;
class PromiseTracker;
class V8InspectorSessionImpl;
+class V8Regex;
class V8StackTraceImpl;
namespace protocol {
@@ -130,9 +131,12 @@ public:
PassOwnPtr<protocol::Runtime::CallArgument> newValue,
const String16& callFrame) override;
void setAsyncCallStackDepth(ErrorString*, int depth) override;
- void setBlackboxedRanges(ErrorString*,
- const String16& scriptId,
- PassOwnPtr<protocol::Array<protocol::Debugger::ScriptPosition>> positions) override;
+ void setBlackboxPatterns(ErrorString*,
+ PassOwnPtr<protocol::Array<String16>> patterns) override;
+ void setScriptBlackboxed(ErrorString*,
+ const Maybe<String16>& hash,
+ const Maybe<String16>& url,
+ const Maybe<protocol::Array<protocol::Runtime::SourceRange>>& ranges) override;
void schedulePauseOnNextStatement(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) override;
void cancelPauseOnNextStatement() override;
@@ -240,8 +244,15 @@ private:
#if ENABLE(ASSERT)
protocol::Vector<void*> m_currentTasks;
#endif
- protocol::Vector<OwnPtr<V8StackTraceImpl>> m_currentStacks;
- protocol::HashMap<String16, protocol::Vector<std::pair<int, int>>> m_blackboxedPositions;
+ Vector<OwnPtr<V8StackTraceImpl>> m_currentStacks;
dgozman 2016/04/20 02:06:40 undo
+
+ using BlackboxRangesByString = protocol::HashMap<String16, Vector<std::pair<int, int>>>;
dgozman 2016/04/20 02:06:40 BlackboxPositionsById
+ void restoreBlackboxScripts(const String16& key, BlackboxRangesByString&);
dgozman 2016/04/20 02:06:40 restoreBlackboxedPositions
+ void restoreBlackboxRanges(const String16& key, BlackboxRangesByString&);
dgozman 2016/04/20 02:06:40 restoreBlackboxedPatterns
+
+ OwnPtr<V8Regex> m_blackboxPattern;
+ BlackboxRangesByString m_blackboxRangesByHash;
+ BlackboxRangesByString m_blackboxRangesByURL;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698