Remove a few more char* members from structs/classes.

Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns /char\*\sm_/
and /m_.*=.*\.c_str/ which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (it is binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.

Committed: https://pdfium.googlesource.com/pdfium/+/4d31d0c653cf66f72bdef7cebbf7cff45d33f6c6

[Tom Sepez, 2016-04-19 20:34:11]

Description was changed from

==========
Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns 'char\*\sm_'
and 'm_.*=.*\.c_str' which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (its binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.
==========

to

==========
Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns /char\*\sm_/
and /m_.*=.*\.c_str/ which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (its binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.
==========

[Tom Sepez, 2016-04-19 20:35:29]

Description was changed from

==========
Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns /char\*\sm_/
and /m_.*=.*\.c_str/ which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (its binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.
==========

to

==========
Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns /char\*\sm_/
and /m_.*=.*\.c_str/ which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (it is binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.
==========

[Tom Sepez, 2016-04-19 20:36:02]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-19 20:36:02]

Lei, for review.  Follow-up based on pattern in previous bug.

[Lei Zhang, 2016-04-19 21:10:24]

lgtm

[Tom Sepez, 2016-04-19 21:11:38]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:11:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902953002/1

[commit-bot: I haz the power, 2016-04-19 21:12:05]

Description was changed from

==========
Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns /char\*\sm_/
and /m_.*=.*\.c_str/ which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (it is binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.
==========

to

==========
Remove a few more char* members from structs/classes.

This is a result of looking for the anti-paterns /char\*\sm_/
and /m_.*=.*\.c_str/ which indicate that a class may be using
the contents of a string without extending the lifetime of
the underlying storage.

Along the way, change to uint8_t in fx_dib; this is unrelated but
avoids grep hits (it is binary, not chars anyways).

Also remove two string operators that make it easy to assign in
a manner that does not extend contents lifetime.

Committed:
https://pdfium.googlesource.com/pdfium/+/4d31d0c653cf66f72bdef7cebbf7cff45d33...
==========

[commit-bot: I haz the power, 2016-04-19 21:12:06]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4d31d0c653cf66f72bdef7cebbf7cff45d33...