Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1902953002: Remove a few more char* members from structs/classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfdoc/doc_form.cpp ('k') | core/fxge/dib/dib_int.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/include/fx_string.h
diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h
index 2fabee39cf9cfc5ef65a3587be91b029cd1b567c..10a70d9334b268cfb197b96894e306a9386d8157 100644
--- a/core/fxcrt/include/fx_string.h
+++ b/core/fxcrt/include/fx_string.h
@@ -74,8 +74,6 @@ class CFX_ByteStringC {
return *this;
}
- CFX_ByteStringC& operator=(const CFX_ByteString& src);
-
bool operator==(const char* ptr) const {
return FXSYS_strlen(ptr) == m_Length &&
FXSYS_memcmp(ptr, m_Ptr, m_Length) == 0;
@@ -285,12 +283,6 @@ class CFX_ByteString {
friend class fxcrt_ByteStringConcat_Test;
};
-inline CFX_ByteStringC& CFX_ByteStringC::operator=(const CFX_ByteString& src) {
- m_Ptr = src.raw_str();
- m_Length = src.GetLength();
- return *this;
-}
-
inline bool operator==(const char* lhs, const CFX_ByteString& rhs) {
return rhs == lhs;
}
@@ -398,8 +390,6 @@ class CFX_WideStringC {
return *this;
}
- CFX_WideStringC& operator=(const CFX_WideString& src);
-
bool operator==(const wchar_t* ptr) const {
return FXSYS_wcslen(ptr) == m_Length && wmemcmp(ptr, m_Ptr, m_Length) == 0;
}
@@ -611,12 +601,6 @@ class CFX_WideString {
friend class fxcrt_WideStringConcatInPlace_Test;
};
-inline CFX_WideStringC& CFX_WideStringC::operator=(const CFX_WideString& src) {
- m_Ptr = src.c_str();
- m_Length = src.GetLength();
- return *this;
-}
-
inline CFX_WideString operator+(const CFX_WideStringC& str1,
const CFX_WideStringC& str2) {
return CFX_WideString(str1, str2);
« no previous file with comments | « core/fpdfdoc/doc_form.cpp ('k') | core/fxge/dib/dib_int.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698