Remove a few more char* members from structs/classes.

core/fxcrt/include/fx_string.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_FXCRT_INCLUDE_FX_STRING_H_
 #define CORE_FXCRT_INCLUDE_FX_STRING_H_
 
 #include <stdint.h>  // For intptr_t.
@@ skipping 56 matching lines @@
     m_Length = m_Ptr ? FXSYS_strlen(src) : 0;
     return *this;
   }
 
   CFX_ByteStringC& operator=(const CFX_ByteStringC& src) {
     m_Ptr = src.m_Ptr;
     m_Length = src.m_Length;
     return *this;
   }
 
-  CFX_ByteStringC& operator=(const CFX_ByteString& src);
-
   bool operator==(const char* ptr) const {
     return FXSYS_strlen(ptr) == m_Length &&
            FXSYS_memcmp(ptr, m_Ptr, m_Length) == 0;
   }
   bool operator==(const CFX_ByteStringC& other) const {
     return other.m_Length == m_Length &&
            FXSYS_memcmp(other.m_Ptr, m_Ptr, m_Length) == 0;
   }
   bool operator!=(const char* ptr) const { return !(*this == ptr); }
   bool operator!=(const CFX_ByteStringC& other) const {
@@ skipping 189 matching lines @@
   void AllocCopy(CFX_ByteString& dest,
                  FX_STRSIZE nCopyLen,
                  FX_STRSIZE nCopyIndex) const;
   void AssignCopy(const FX_CHAR* pSrcData, FX_STRSIZE nSrcLen);
   void Concat(const FX_CHAR* lpszSrcData, FX_STRSIZE nSrcLen);
 
   CFX_RetainPtr<StringData> m_pData;
   friend class fxcrt_ByteStringConcat_Test;
 };
 
-inline CFX_ByteStringC& CFX_ByteStringC::operator=(const CFX_ByteString& src) {
-  m_Ptr = src.raw_str();
-  m_Length = src.GetLength();
-  return *this;
-}
-
 inline bool operator==(const char* lhs, const CFX_ByteString& rhs) {
   return rhs == lhs;
 }
 inline bool operator==(const CFX_ByteStringC& lhs, const CFX_ByteString& rhs) {
   return rhs == lhs;
 }
 inline bool operator!=(const char* lhs, const CFX_ByteString& rhs) {
   return rhs != lhs;
 }
 inline bool operator!=(const CFX_ByteStringC& lhs, const CFX_ByteString& rhs) {
@@ skipping 87 matching lines @@
     m_Length = FXSYS_wcslen(src);
     return *this;
   }
 
   CFX_WideStringC& operator=(const CFX_WideStringC& src) {
     m_Ptr = src.m_Ptr;
     m_Length = src.m_Length;
     return *this;
   }
 
-  CFX_WideStringC& operator=(const CFX_WideString& src);
-
   bool operator==(const wchar_t* ptr) const {
     return FXSYS_wcslen(ptr) == m_Length && wmemcmp(ptr, m_Ptr, m_Length) == 0;
   }
   bool operator==(const CFX_WideStringC& str) const {
     return str.m_Length == m_Length && wmemcmp(str.m_Ptr, m_Ptr, m_Length) == 0;
   }
   bool operator!=(const wchar_t* ptr) const { return !(*this == ptr); }
   bool operator!=(const CFX_WideStringC& str) const { return !(*this == str); }
 
   const FX_WCHAR* c_str() const { return m_Ptr; }
@@ skipping 191 matching lines @@
   void AllocCopy(CFX_WideString& dest,
                  FX_STRSIZE nCopyLen,
                  FX_STRSIZE nCopyIndex) const;
   void AssignCopy(const FX_WCHAR* pSrcData, FX_STRSIZE nSrcLen);
   void Concat(const FX_WCHAR* lpszSrcData, FX_STRSIZE nSrcLen);
 
   CFX_RetainPtr<StringData> m_pData;
   friend class fxcrt_WideStringConcatInPlace_Test;
 };
 
-inline CFX_WideStringC& CFX_WideStringC::operator=(const CFX_WideString& src) {
-  m_Ptr = src.c_str();
-  m_Length = src.GetLength();
-  return *this;
-}
-
 inline CFX_WideString operator+(const CFX_WideStringC& str1,
                                 const CFX_WideStringC& str2) {
   return CFX_WideString(str1, str2);
 }
 inline CFX_WideString operator+(const CFX_WideStringC& str1,
                                 const FX_WCHAR* str2) {
   return CFX_WideString(str1, str2);
 }
 inline CFX_WideString operator+(const FX_WCHAR* str1,
                                 const CFX_WideStringC& str2) {
@@ skipping 53 matching lines @@
 }
 
 FX_FLOAT FX_atof(const CFX_ByteStringC& str);
 inline FX_FLOAT FX_atof(const CFX_WideStringC& wsStr) {
   return FX_atof(FX_UTF8Encode(wsStr.c_str(), wsStr.GetLength()).c_str());
 }
 void FX_atonum(const CFX_ByteStringC& str, FX_BOOL& bInteger, void* pData);
 FX_STRSIZE FX_ftoa(FX_FLOAT f, FX_CHAR* buf);
 
 #endif  // CORE_FXCRT_INCLUDE_FX_STRING_H_