MD Settings: simplify language model and data binding

MD Settings: simplify language model and data binding

Several data model changes that make things less confusing and
data binding more predictable. Useful for the Input Methods CL.

BUG=512479
Committed: https://crrev.com/abbd180debcb8fe325e91b09b0cee7902a3b3cbc
Cr-Commit-Position: refs/heads/master@{#389348}

[michaelpg, 2016-04-20 09:16:38]

Description was changed from

==========
MD Settings: simplify language model and data binding

BUG=
==========

to

==========
MD Settings: simplify language model and data binding

Several data model changes that make things less confusing and
data binding more predictable. Useful for the Input Methods CL.

BUG=512479
==========

[michaelpg, 2016-04-20 09:16:38]

michaelpg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[michaelpg, 2016-04-20 19:37:18]

Patchset #3 (id:40001) has been deleted

[michaelpg, 2016-04-20 19:37:28]

PTAL.

[stevenjb, 2016-04-20 20:40:50]

Mostly nits

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages.js (right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages.js:293: * @template T
nit: Can the @template be listed first? It seems confusing here. Ignore if this
ordering is standard.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_types.js
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_types.js:12: *
@typedef {{language: !chrome.languageSettingsPrivate.Language,
nit: language on a new line seems more common (e.g. like at line 26).

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_types.js:15: *       
    translateEnabled: boolean}}
nit: boolean,\n }}

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/manage_languages_page.html
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:26:
<h2 i18n-content="enabledLanguages"></h2>
$i18n{}

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:39:
<h2 i18n-content="allLanguages"></h2>
$i18n{}

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:41:
<iron-list items="{{languages.supported}}" as="item">
as= not needed?

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/manage_languages_page.js
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.js:40: *
@param {!Object} change
It is a little confusing as to what this is and why we need to pass it. Could
you type and document it?

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.js:52: *
@param {!Object} change
Same here.

[michaelpg, 2016-04-20 23:19:59]

PTAL, thanks. I moved the i18n stuff to a pre-CL.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages.js (right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages.js:293: * @template T
On 2016/04/20 20:40:49, stevenjb wrote:
> nit: Can the @template be listed first? It seems confusing here. Ignore if
this
> ordering is standard.

It's the more common way (we don't have many examples) and it follows the
examples of
https://developers.google.com/closure/compiler/docs/js-for-compiler#declaring...

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_types.js
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_types.js:12: *
@typedef {{language: !chrome.languageSettingsPrivate.Language,
On 2016/04/20 20:40:50, stevenjb wrote:
> nit: language on a new line seems more common (e.g. like at line 26).

Done.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_types.js:15: *       
    translateEnabled: boolean}}
On 2016/04/20 20:40:50, stevenjb wrote:
> nit: boolean,\n }}

Done.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/manage_languages_page.html
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:26:
<h2 i18n-content="enabledLanguages"></h2>
On 2016/04/20 20:40:50, stevenjb wrote:
> $i18n{}

I've done this separately in crrev.com/1905533005 with dschuyler@ to review.

Then rebased this patch on that one.

You can see the changes including i18n by comparing with patch set 2, and the
changes that are just from this CL by comparing to base.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:39:
<h2 i18n-content="allLanguages"></h2>
On 2016/04/20 20:40:50, stevenjb wrote:
> $i18n{}

Done.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:41:
<iron-list items="{{languages.supported}}" as="item">
On 2016/04/20 20:40:50, stevenjb wrote:
> as= not needed?

Done.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/manage_languages_page.js
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.js:40: *
@param {!Object} change
On 2016/04/20 20:40:50, stevenjb wrote:
> It is a little confusing as to what this is and why we need to pass it. Could
> you type and document it?

It's awkward to type, and @unused isn't a thing, but I did my best to clarify
it.

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.js:52: *
@param {!Object} change
On 2016/04/20 20:40:50, stevenjb wrote:
> Same here.

Done.

[michaelpg, 2016-04-21 03:23:13]

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/manage_languages_page.js
(right):

https://codereview.chromium.org/1902893003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/manage_languages_page.js:40: *
@param {!Object} change
On 2016/04/20 23:19:59, michaelpg wrote:
> On 2016/04/20 20:40:50, stevenjb wrote:
> > It is a little confusing as to what this is and why we need to pass it.
Could
> > you type and document it?
> 
> It's awkward to type, and @unused isn't a thing, but I did my best to clarify
> it.

I've updated this with the comment you suggested in crrev.com/1908483003.

[stevenjb, 2016-04-21 16:13:57]

lgtm

[michaelpg, 2016-04-21 19:02:06]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:02:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902893003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902893003/80001

[commit-bot: I haz the power, 2016-04-21 19:23:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:23:15]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[michaelpg, 2016-04-23 00:33:51]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-04-23 00:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902893003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902893003/80001

[michaelpg, 2016-04-23 00:51:08]

Patchset #5 (id:100001) has been deleted

[michaelpg, 2016-04-23 00:51:16]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-04-23 00:51:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902893003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902893003/80001

[commit-bot: I haz the power, 2016-04-23 02:42:44]

Description was changed from

==========
MD Settings: simplify language model and data binding

Several data model changes that make things less confusing and
data binding more predictable. Useful for the Input Methods CL.

BUG=512479
==========

to

==========
MD Settings: simplify language model and data binding

Several data model changes that make things less confusing and
data binding more predictable. Useful for the Input Methods CL.

BUG=512479
==========

[commit-bot: I haz the power, 2016-04-23 02:42:45]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-04-23 02:44:11]

Description was changed from

==========
MD Settings: simplify language model and data binding

Several data model changes that make things less confusing and
data binding more predictable. Useful for the Input Methods CL.

BUG=512479
==========

to

==========
MD Settings: simplify language model and data binding

Several data model changes that make things less confusing and
data binding more predictable. Useful for the Input Methods CL.

BUG=512479

Committed: https://crrev.com/abbd180debcb8fe325e91b09b0cee7902a3b3cbc
Cr-Commit-Position: refs/heads/master@{#389348}
==========

[commit-bot: I haz the power, 2016-04-23 02:44:12]

Patchset 4 (id:??) landed as
https://crrev.com/abbd180debcb8fe325e91b09b0cee7902a3b3cbc
Cr-Commit-Position: refs/heads/master@{#389348}