chrome/browser/resources/settings/languages_page/languages_page.html - Issue 1902893003: MD Settings: simplify language model and data binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 1902893003: MD Settings: simplify language model and data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comment based on other CL feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages.js ('k') | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 88953efa9920568ba73a92f96a90d15a9299b7d5..f8f3fb5fe7b7c75b027a44d2f19d666457ecb0e0 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -38,7 +38,7 @@

</div>

<iron-collapse id="languagesCollapse" opened="[[languagesOpened_]]">

- <template is="dom-repeat" items="{{languages.enabledLanguages}}">

+ <template is="dom-repeat" items="{{languages.enabled}}">

<div class$="list-item [[getLanguageItemClass_(

item.language.code, prefs.intl.app_locale.value)]]"

on-tap="onLanguageTap_">

@@ -108,11 +108,11 @@

<iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">

<template is="dom-repeat"

- items="[[spellCheckLanguages_(languages.enabledLanguages.*)]]">

+ items="[[spellCheckLanguages_(languages.enabled.*)]]">

<paper-checkbox

- checked="[[item.state.spellCheckEnabled]]"

+ checked="[[item.spellCheckEnabled]]"

on-change="onSpellCheckChange_">

[[item.language.displayName]]

</paper-checkbox>