Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1905533005: MD Settings: Use $i18n{} templating in Languages pages (Closed)

Created:
4 years, 8 months ago by michaelpg
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Use $i18n{} templating in Languages pages BUG=506009 R=dschuyler@chromium.org Committed: https://crrev.com/76cbb00df78d401c1466537524846f5b50e0ffa6 Cr-Commit-Position: refs/heads/master@{#388669}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
michaelpg
PTAL - first time using $i18n
4 years, 8 months ago (2016-04-20 23:16:17 UTC) #1
dschuyler
lgtm
4 years, 8 months ago (2016-04-20 23:34:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905533005/1
4 years, 8 months ago (2016-04-21 01:01:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 03:04:11 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:30:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/76cbb00df78d401c1466537524846f5b50e0ffa6
Cr-Commit-Position: refs/heads/master@{#388669}

Powered by Google App Engine
This is Rietveld 408576698