Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1935613002: cc: Move filter outset in content rect calculation (Closed)

Created:
4 years, 7 months ago by weiliangc
Modified:
4 years, 7 months ago
Reviewers:
enne (OOO)
CC:
ajuma, cc-bugs_chromium.org, chromium-reviews, Stephen White
Base URL:
https://chromium.googlesource.com/chromium/src.git@visiblerectcleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move filter outset in content rect calculation When filter outset moves pixel, it should be in local space. Damage tracker should not need to do the transform when the whole render surface is damaged. R=enne BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d68cf7190ac02304f83923a2837e656a12d0f1a2 Cr-Commit-Position: refs/heads/master@{#391091}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -34 lines) Patch
M cc/layers/render_surface_impl.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 chunk +15 lines, -16 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 chunks +70 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
weiliangc
Was looking at drawable_content_rect calculation. Filter outset should happen in local space, and need to ...
4 years, 7 months ago (2016-05-02 15:04:06 UTC) #2
enne (OOO)
lgtm
4 years, 7 months ago (2016-05-02 18:05:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935613002/20001
4 years, 7 months ago (2016-05-02 21:18:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 23:29:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:30:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d68cf7190ac02304f83923a2837e656a12d0f1a2
Cr-Commit-Position: refs/heads/master@{#391091}

Powered by Google App Engine
This is Rietveld 408576698