Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1902683004: Set bootstrap toolchain's toolchain_os to target_os (Closed)

Created:
4 years, 8 months ago by hashimoto
Modified:
4 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, Dirk Pranke
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Set bootstrap toolchain's toolchain_os to target_os When building for Chrome OS, toolchain_os should be "chromeos" Chrome side change: https://codereview.chromium.org/1901353002 BUG=604971 TEST=In chrome-sdk, gn gen --args=$GN_ARGS out/gn && ninja -C out/gn chrome Committed: https://chromium.googlesource.com/native_client/src/native_client/+/e00683860ca12657641baaadcbd9661c1fb82f51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/trusted/service_runtime/linux/toolchain/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
hashimoto
cc: dpranke@chromium.org
4 years, 8 months ago (2016-04-20 05:17:10 UTC) #3
Roland McGrath
lgtm
4 years, 8 months ago (2016-04-20 18:41:54 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-20 22:21:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902683004/1
4 years, 8 months ago (2016-04-21 00:30:17 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 01:06:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/e00683860...

Powered by Google App Engine
This is Rietveld 408576698