Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1901353002:
Use target_sysroot when building for target OS on target CPU (Closed)
DescriptionUse target_sysroot when building for target OS on target CPU
nacl's bootstrap toolchain should also use target_sysroot.
Nacl side change: https://codereview.chromium.org/1902683004/
BUG=604971
TEST=Remove build/linux/debian_wheezy_arm-sysroot, enter chrome-sdk with an arm board, gn gen --args=$GN_ARGS out/gn && ninja -C out/gn
Committed: https://crrev.com/3a1ce21a7cc8c9301173b595764b6545785804e8
Cr-Commit-Position: refs/heads/master@{#388668}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Revert !is_chromeos #Messages
Total messages: 19 (8 generated)
hashimoto@chromium.org changed reviewers: + dpranke@chromium.org
https://codereview.chromium.org/1901353002/diff/1/build/config/sysroot.gni File build/config/sysroot.gni (left): https://codereview.chromium.org/1901353002/diff/1/build/config/sysroot.gni#ol... build/config/sysroot.gni:36: } else if (is_linux && !is_chromeos && use_sysroot) { This !is_chromeos has nothing to do with the problem being fixed, but I'm just removing it now as it's redundant. IIUC this !is_chromeos was introduced in https://codereview.chromium.org/115643002, but it's unneeded. When building for real Chrome OS devices, we always set target_sysroot so we never reach here. When building Linux Chrome with target_os="chromeos" (this is only used by UI developers), we should just do the same thing as Linux Chrome.
mcgrathr@chromium.org changed reviewers: + mcgrathr@chromium.org
lgtm
lgtm
The CQ bit was checked by hashimoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901353002/1
https://codereview.chromium.org/1901353002/diff/1/build/config/sysroot.gni File build/config/sysroot.gni (left): https://codereview.chromium.org/1901353002/diff/1/build/config/sysroot.gni#ol... build/config/sysroot.gni:36: } else if (is_linux && !is_chromeos && use_sysroot) { On 2016/04/20 05:28:58, hashimoto wrote: > This !is_chromeos has nothing to do with the problem being fixed, but I'm just > removing it now as it's redundant. > > IIUC this !is_chromeos was introduced in > https://codereview.chromium.org/115643002, but it's unneeded. > When building for real Chrome OS devices, we always set target_sysroot so we > never reach here. > When building Linux Chrome with target_os="chromeos" (this is only used by UI > developers), we should just do the same thing as Linux Chrome. Ugh, this !is_chromeos is actually needed because debian sysroot is too old to build Chrome OS code. This means we rely on developers to have sufficiently new header files in their workstations, but it shouldn't matter much as this path will be only used by UI developers. Reverted this part.
The CQ bit was checked by hashimoto@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, mcgrathr@chromium.org Link to the patchset: https://codereview.chromium.org/1901353002/#ps20001 (title: "Revert !is_chromeos")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901353002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hashimoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901353002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use target_sysroot when building for target OS on target CPU nacl's bootstrap toolchain should also use target_sysroot. Nacl side change: https://codereview.chromium.org/1902683004/ BUG=604971 TEST=Remove build/linux/debian_wheezy_arm-sysroot, enter chrome-sdk with an arm board, gn gen --args=$GN_ARGS out/gn && ninja -C out/gn ========== to ========== Use target_sysroot when building for target OS on target CPU nacl's bootstrap toolchain should also use target_sysroot. Nacl side change: https://codereview.chromium.org/1902683004/ BUG=604971 TEST=Remove build/linux/debian_wheezy_arm-sysroot, enter chrome-sdk with an arm board, gn gen --args=$GN_ARGS out/gn && ninja -C out/gn Committed: https://crrev.com/3a1ce21a7cc8c9301173b595764b6545785804e8 Cr-Commit-Position: refs/heads/master@{#388668} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3a1ce21a7cc8c9301173b595764b6545785804e8 Cr-Commit-Position: refs/heads/master@{#388668} |
