Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

R=
BUG=604644
Committed: https://crrev.com/40ebec288b976477aaa318b26899dc08f5b15426
Cr-Commit-Position: refs/heads/master@{#388209}

[sof, 2016-04-19 09:59:18]

sigbjornf@opera.com changed reviewers:
+ mkwst@chromium.org, philipj@opera.com

[sof, 2016-04-19 09:59:18]

please take a look.

No web-facing changes here (at least that's the intent/expectation), but move
forward to 2016 in terms of underlying interface names.

[sof, 2016-04-19 10:01:31]

https://codereview.chromium.org/1902683003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLHyperlinkElementUtils.idl (right):

https://codereview.chromium.org/1902683003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLHyperlinkElementUtils.idl:11:
[NotEnumerable, ImplementedAs=href] USVString toString();
I can't say I understand why this toString() is needed, but not on URL. (see
ps#1 for what happens if you leave it out.)

[sof, 2016-04-19 11:04:29]

Description was changed from

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

Given that the IDL stringifier implementation is now in place, switch
to using it as well.

R=
BUG=604644
==========

to

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

With the IDL stringifier keyword now being supported, make use of it.

R=
BUG=604644
==========

[sof, 2016-04-19 11:05:15]

https://codereview.chromium.org/1902683003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLHyperlinkElementUtils.idl (right):

https://codereview.chromium.org/1902683003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLHyperlinkElementUtils.idl:11:
[NotEnumerable, ImplementedAs=href] USVString toString();
On 2016/04/19 10:01:31, sof wrote:
> I can't say I understand why this toString() is needed, but not on URL. (see
> ps#1 for what happens if you leave it out.)

https://codereview.chromium.org/1901983002/ mostly addresses this infelicity
(modulo NotEnumerable)

[sof, 2016-04-19 11:48:21]

Description was changed from

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

With the IDL stringifier keyword now being supported, make use of it.

R=
BUG=604644
==========

to

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

R=
BUG=604644
==========

[sof, 2016-04-19 11:52:00]

https://codereview.chromium.org/1902683003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLHyperlinkElementUtils.idl (right):

https://codereview.chromium.org/1902683003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLHyperlinkElementUtils.idl:11:
[NotEnumerable, ImplementedAs=href] USVString toString();
On 2016/04/19 11:05:15, sof wrote:
> On 2016/04/19 10:01:31, sof wrote:
> > I can't say I understand why this toString() is needed, but not on URL. (see
> > ps#1 for what happens if you leave it out.)
> 
> https://codereview.chromium.org/1901983002/ mostly addresses this infelicity
> (modulo NotEnumerable)

We should try to address not having enumerable toString()s, which prevents the
use of 'stringifier', but not here. Added TODOs.

[philipj_slow, 2016-04-19 12:40:00]

lgtm

https://codereview.chromium.org/1902683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/URL.idl (right):

https://codereview.chromium.org/1902683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/URL.idl:47: // TODO(sof): 'stringifier'
entails an enumerable toString(),
There are a few cases of "[NotEnumerable] stringifier" already, the one in
DOMTokenList with a FIXME even. If ImplementedAs works together with
stringifier, then using that would be a teeny bit nicer I think. You just moved
this code, so you pick :)

[sof, 2016-04-19 12:46:03]

https://codereview.chromium.org/1902683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/URL.idl (right):

https://codereview.chromium.org/1902683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/URL.idl:47: // TODO(sof): 'stringifier'
entails an enumerable toString(),
On 2016/04/19 12:40:00, philipj_slow wrote:
> There are a few cases of "[NotEnumerable] stringifier" already, the one in
> DOMTokenList with a FIXME even. If ImplementedAs works together with
> stringifier, then using that would be a teeny bit nicer I think. You just
moved
> this code, so you pick :)

That alternative doesn't work I'm afraid with
https://codereview.chromium.org/1901983002 in scope, so keeping it as-is.

[philipj_slow, 2016-04-19 12:52:25]

https://codereview.chromium.org/1902683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/URL.idl (right):

https://codereview.chromium.org/1902683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/URL.idl:47: // TODO(sof): 'stringifier'
entails an enumerable toString(),
On 2016/04/19 12:46:03, sof wrote:
> On 2016/04/19 12:40:00, philipj_slow wrote:
> > There are a few cases of "[NotEnumerable] stringifier" already, the one in
> > DOMTokenList with a FIXME even. If ImplementedAs works together with
> > stringifier, then using that would be a teeny bit nicer I think. You just
> moved
> > this code, so you pick :)
> 
> That alternative doesn't work I'm afraid with
> https://codereview.chromium.org/1901983002 in scope, so keeping it as-is.

Acknowledged.

[sof, 2016-04-19 13:32:58]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-04-19 13:33:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902683003/60001

[commit-bot: I haz the power, 2016-04-19 15:20:32]

Description was changed from

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

R=
BUG=604644
==========

to

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

R=
BUG=604644
==========

[commit-bot: I haz the power, 2016-04-19 15:20:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:12:19]

Description was changed from

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

R=
BUG=604644
==========

to

==========
Rename URLUtils interface as HTMLHyperlinkElementUtils and update.

Follow the HTML spec for HTMLAnchorElement + HTMLAreaElement, and have
them implement the [NoInterfaceObject] HTMLHyperlinkElementUtils
interface, rather than the previous URLUtils which has now been
retired / divided up.

The other implementation of URLUtils, URL, now define the attributes
directly (with the addition of a searchParams getter.)  Update its IDL
also.

R=
BUG=604644

Committed: https://crrev.com/40ebec288b976477aaa318b26899dc08f5b15426
Cr-Commit-Position: refs/heads/master@{#388209}
==========

[commit-bot: I haz the power, 2016-04-22 19:12:20]

Patchset 4 (id:??) landed as
https://crrev.com/40ebec288b976477aaa318b26899dc08f5b15426
Cr-Commit-Position: refs/heads/master@{#388209}