Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1901983002: IDL: Merge stringifier/serializer definition from implemented interface (Closed)

Created:
4 years, 8 months ago by Jens Widell
Modified:
4 years, 8 months ago
Reviewers:
haraken, sof
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL: Merge stringifier/serializer definition from implemented interface A stringifier defined in a supplemental interface was not merged into the primary interface, which meant that no 'toString' operation was defined. Same for serializer definitions and the 'toJSON' operation. This does not currently change generated code; no supplemental interface defines a stringifier or serializer. BUG=306606, 469650 Committed: https://crrev.com/a32ab4b9b68aba6652d992f1144cc04ea023311e Cr-Commit-Position: refs/heads/master@{#388191}

Patch Set 1 #

Patch Set 2 : as a test, move defs from TestInterface to TestImplements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestImplements.idl View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jens Widell
PTAL
4 years, 8 months ago (2016-04-19 10:55:45 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-19 10:58:37 UTC) #4
Jens Widell
On 2016/04/19 at 10:58:37, haraken wrote: > LGTM Thanks! Cool to still gets instant reviews ...
4 years, 8 months ago (2016-04-19 11:03:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901983002/20001
4 years, 8 months ago (2016-04-19 11:03:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 12:38:34 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:40:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a32ab4b9b68aba6652d992f1144cc04ea023311e
Cr-Commit-Position: refs/heads/master@{#388191}

Powered by Google App Engine
This is Rietveld 408576698