Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/core/dom/URL.idl

Issue 1902683003: Rename URLUtils interface as HTMLHyperlinkElementUtils and update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: keep toString()s as non-enumerable for now Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/dom/URLUtils.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/URL.idl
diff --git a/third_party/WebKit/Source/core/dom/URL.idl b/third_party/WebKit/Source/core/dom/URL.idl
index 449b13bf27b79a74a8e0bcc4bcac6077f2e514f6..35f6f7fe2b08aa6811828b2733b510d9b41c7c2d 100644
--- a/third_party/WebKit/Source/core/dom/URL.idl
+++ b/third_party/WebKit/Source/core/dom/URL.idl
@@ -43,7 +43,28 @@
// TODO(philipj): The return type should not be nullable.
[RaisesException, CallWith=ExecutionContext] static DOMString? createObjectURL(Blob blob);
[CallWith=ExecutionContext] static void revokeObjectURL(DOMString url);
+
+ // TODO(sof): 'stringifier' entails an enumerable toString(),
philipj_slow 2016/04/19 12:40:00 There are a few cases of "[NotEnumerable] stringif
sof 2016/04/19 12:46:03 That alternative doesn't work I'm afraid with http
philipj_slow 2016/04/19 12:52:25 Acknowledged.
+ // http://heycam.github.io/webidl/#es-stringifier
+ // something URL currently doesn't provide. Switch it over to being
+ // enumerable (http://crbug.com/306606).
+ //
+ // Until that time, do not use 'stringifier'.
+ // stringifier attribute USVString href;
+ attribute USVString href;
+ [NotEnumerable, ImplementedAs=href] USVString toString();
+
+ readonly attribute USVString origin;
+
+ attribute USVString protocol;
+ attribute USVString username;
+ attribute USVString password;
+ attribute USVString host;
+ attribute USVString hostname;
+ attribute USVString port;
+ attribute USVString pathname;
+ attribute USVString search;
readonly attribute URLSearchParams searchParams;
+ attribute USVString hash;
};
-URL implements URLUtils;
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/dom/URLUtils.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698