Introduce components/display_compositor

Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true

Committed: https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa
Cr-Commit-Position: refs/heads/master@{#388829}

[Fady Samuel, 2016-04-18 17:47:57]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 17:48:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/20001

[commit-bot: I haz the power, 2016-04-18 17:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 17:53:33]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-04-18 19:31:29]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 19:32:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/40001

[commit-bot: I haz the power, 2016-04-18 19:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 19:38:02]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Fady Samuel, 2016-04-18 23:47:58]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 23:48:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/60001

[commit-bot: I haz the power, 2016-04-18 23:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 23:53:22]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-04-19 19:49:22]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 19:49:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/80001

[commit-bot: I haz the power, 2016-04-19 19:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 19:53:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-04-19 19:57:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 19:57:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/100001

[commit-bot: I haz the power, 2016-04-19 20:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 20:02:33]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-04-19 20:14:10]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 20:14:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/120001

[commit-bot: I haz the power, 2016-04-19 20:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 20:19:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-04-19 21:18:52]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 21:19:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/140001

[commit-bot: I haz the power, 2016-04-19 21:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:22:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fady Samuel, 2016-04-19 21:33:19]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 21:33:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/160001

[commit-bot: I haz the power, 2016-04-19 21:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:45:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-19 22:35:54]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 22:36:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/180001

[commit-bot: I haz the power, 2016-04-19 22:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 22:45:31]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-19 22:50:18]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 22:50:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/200001

[commit-bot: I haz the power, 2016-04-19 22:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 22:59:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-19 23:08:49]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 23:09:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/210001

[commit-bot: I haz the power, 2016-04-19 23:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 23:19:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-20 00:29:27]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 00:29:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/230001

[commit-bot: I haz the power, 2016-04-20 00:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 00:39:21]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-20 01:23:57]

Description was changed from

==========
[WIP] Introduce components/display_compositor

BUG=
==========

to

==========
[WIP] Introduce components/display_compositor

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-04-20 01:25:30]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 01:25:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/250001

[Fady Samuel, 2016-04-20 01:27:16]

Description was changed from

==========
[WIP] Introduce components/display_compositor

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-04-20 01:27:59]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[commit-bot: I haz the power, 2016-04-20 01:35:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 01:35:46]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chromium-reviews, 2016-04-20 01:39:29]

GLHelper isn't used by display compositor, it's used by reflector and
screenshots and stuff.

On Tue, Apr 19, 2016 at 6:28 PM, <fsamuel@chromium.org> wrote:

> Reviewers: piman
> CL: https://codereview.chromium.org/1902463002/
>
> Description:
> Introduce components/display_compositor
>
> We would like to share BufferQueue, GLHelper and later other parts
> of content/browser/compositor in Mus. This CL introduces a new
> display_compositor component and moves BufferQueue, GLHelper and
> friends to components/display_compositor.
>
> BUG=601867
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+597, -6548 lines):
> M .gn
> M BUILD.gn
> M build/gn_migration.gypi
> M cc/cc_tests.gyp
> M components/components.gyp
> A components/display_compositor.gypi
> A components/display_compositor/BUILD.gn
> A components/display_compositor/DEPS
> A + components/display_compositor/OWNERS
> A + components/display_compositor/buffer_queue.h
> A + components/display_compositor/buffer_queue.cc
> A + components/display_compositor/buffer_queue_unittest.cc
> A components/display_compositor/display_compositor_export.h
> A components/display_compositor/display_compositor_test_suite.h
> A + components/display_compositor/display_compositor_test_suite.cc
> A + components/display_compositor/gl_helper.h
> A + components/display_compositor/gl_helper.cc
> A + components/display_compositor/gl_helper_benchmark.cc
> A + components/display_compositor/gl_helper_readback_support.h
> A + components/display_compositor/gl_helper_readback_support.cc
> A + components/display_compositor/gl_helper_scaling.h
> A + components/display_compositor/gl_helper_scaling.cc
> A + components/display_compositor/gl_helper_unittest.cc
> A + components/display_compositor/run_all_unittests.cc
> A + components/display_compositor/yuv_readback_unittest.cc
> M content/browser/BUILD.gn
> M content/browser/compositor/DEPS
> D content/browser/compositor/buffer_queue.h
> D content/browser/compositor/buffer_queue.cc
> D content/browser/compositor/buffer_queue_unittest.cc
> D content/browser/compositor/gl_helper.h
> D content/browser/compositor/gl_helper.cc
> D content/browser/compositor/gl_helper_benchmark.cc
> D content/browser/compositor/gl_helper_readback_support.h
> D content/browser/compositor/gl_helper_readback_support.cc
> D content/browser/compositor/gl_helper_scaling.h
> D content/browser/compositor/gl_helper_scaling.cc
> D content/browser/compositor/gl_helper_unittest.cc
> M content/browser/compositor/gpu_process_transport_factory.h
> M content/browser/compositor/gpu_process_transport_factory.cc
> M
>
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
> M
>
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
> M content/browser/compositor/image_transport_factory.h
> M content/browser/compositor/image_transport_factory_browsertest.cc
> M content/browser/compositor/owned_mailbox.h
> M content/browser/compositor/owned_mailbox.cc
> M content/browser/compositor/reflector_texture.h
> M content/browser/compositor/reflector_texture.cc
> M content/browser/compositor/surface_utils.cc
> M content/browser/compositor/test/no_transport_image_transport_factory.h
> M content/browser/compositor/test/no_transport_image_transport_factory.cc
> D content/browser/compositor/yuv_readback_unittest.cc
> M content/browser/media/capture/DEPS
> M content/browser/media/capture/aura_window_capture_machine.h
> M content/browser/media/capture/aura_window_capture_machine.cc
> M content/browser/renderer_host/DEPS
> M content/browser/renderer_host/compositor_impl_android.cc
> M content/browser/renderer_host/delegated_frame_host.h
> M content/browser/renderer_host/delegated_frame_host.cc
> M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
> M content/browser/renderer_host/media/video_capture_controller.cc
> M content/browser/renderer_host/render_widget_host_view_android.cc
> M content/browser/renderer_host/render_widget_host_view_aura.cc
> M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
> M content/content_browser.gypi
> M content/content_tests.gypi
> M content/test/BUILD.gn
> M testing/buildbot/chromium.fyi.json
> M testing/buildbot/gn_isolate_map.pyl
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rjkroege, 2016-04-20 01:41:40]

On Tuesday, April 19, 2016, Dana Jansens <danakj@google.com> wrote:

> GLHelper isn't used by display compositor, it's used by reflector and
> screenshots and stuff.
>

Not entirely so. Parts are used by c/b/c::BufferQueue which is (in essence)
a delegate of GpuSurfacelessBrowserCompositorOutputSurface




>
> On Tue, Apr 19, 2016 at 6:28 PM, <fsamuel@chromium.org
> <javascript:_e(%7B%7D,'cvml','fsamuel@chromium.org');>> wrote:
>
>> Reviewers: piman
>> CL: https://codereview.chromium.org/1902463002/
>>
>> Description:
>> Introduce components/display_compositor
>>
>> We would like to share BufferQueue, GLHelper and later other parts
>> of content/browser/compositor in Mus. This CL introduces a new
>> display_compositor component and moves BufferQueue, GLHelper and
>> friends to components/display_compositor.
>>
>> BUG=601867
>> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>>
>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+597, -6548 lines):
>> M .gn
>> M BUILD.gn
>> M build/gn_migration.gypi
>> M cc/cc_tests.gyp
>> M components/components.gyp
>> A components/display_compositor.gypi
>> A components/display_compositor/BUILD.gn
>> A components/display_compositor/DEPS
>> A + components/display_compositor/OWNERS
>> A + components/display_compositor/buffer_queue.h
>> A + components/display_compositor/buffer_queue.cc
>> A + components/display_compositor/buffer_queue_unittest.cc
>> A components/display_compositor/display_compositor_export.h
>> A components/display_compositor/display_compositor_test_suite.h
>> A + components/display_compositor/display_compositor_test_suite.cc
>> A + components/display_compositor/gl_helper.h
>> A + components/display_compositor/gl_helper.cc
>> A + components/display_compositor/gl_helper_benchmark.cc
>> A + components/display_compositor/gl_helper_readback_support.h
>> A + components/display_compositor/gl_helper_readback_support.cc
>> A + components/display_compositor/gl_helper_scaling.h
>> A + components/display_compositor/gl_helper_scaling.cc
>> A + components/display_compositor/gl_helper_unittest.cc
>> A + components/display_compositor/run_all_unittests.cc
>> A + components/display_compositor/yuv_readback_unittest.cc
>> M content/browser/BUILD.gn
>> M content/browser/compositor/DEPS
>> D content/browser/compositor/buffer_queue.h
>> D content/browser/compositor/buffer_queue.cc
>> D content/browser/compositor/buffer_queue_unittest.cc
>> D content/browser/compositor/gl_helper.h
>> D content/browser/compositor/gl_helper.cc
>> D content/browser/compositor/gl_helper_benchmark.cc
>> D content/browser/compositor/gl_helper_readback_support.h
>> D content/browser/compositor/gl_helper_readback_support.cc
>> D content/browser/compositor/gl_helper_scaling.h
>> D content/browser/compositor/gl_helper_scaling.cc
>> D content/browser/compositor/gl_helper_unittest.cc
>> M content/browser/compositor/gpu_process_transport_factory.h
>> M content/browser/compositor/gpu_process_transport_factory.cc
>> M content/browser/compositor/gpu_surfaceless_browser_
>> compositor_output_surface.h
>> M content/browser/compositor/gpu_surfaceless_browser_
>> compositor_output_surface.cc
>> M content/browser/compositor/image_transport_factory.h
>> M content/browser/compositor/image_transport_factory_browsertest.cc
>> M content/browser/compositor/owned_mailbox.h
>> M content/browser/compositor/owned_mailbox.cc
>> M content/browser/compositor/reflector_texture.h
>> M content/browser/compositor/reflector_texture.cc
>> M content/browser/compositor/surface_utils.cc
>> M content/browser/compositor/test/no_transport_image_transport_factory.h
>> M content/browser/compositor/test/no_transport_image_transport_factory.cc
>> D content/browser/compositor/yuv_readback_unittest.cc
>> M content/browser/media/capture/DEPS
>> M content/browser/media/capture/aura_window_capture_machine.h
>> M content/browser/media/capture/aura_window_capture_machine.cc
>> M content/browser/renderer_host/DEPS
>> M content/browser/renderer_host/compositor_impl_android.cc
>> M content/browser/renderer_host/delegated_frame_host.h
>> M content/browser/renderer_host/delegated_frame_host.cc
>> M content/browser/renderer_host/media/video_capture_buffer_
>> pool_unittest.cc
>> M content/browser/renderer_host/media/video_capture_controller.cc
>> M content/browser/renderer_host/render_widget_host_view_android.cc
>> M content/browser/renderer_host/render_widget_host_view_aura.cc
>> M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
>> M content/content_browser.gypi
>> M content/content_tests.gypi
>> M content/test/BUILD.gn
>> M testing/buildbot/chromium.fyi.json
>> M testing/buildbot/gn_isolate_map.pyl
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2016-04-20 01:48:26]

GLHelper didn't seem to fit nicely in gpu/ either. We can think about dicing up
and moving parts of GLHelper later. I'd prefer to get this code in a common
place as soon as possible so we can use it in Mus first, and then cleanup the
code, bringing along both Chrome and Mus for the ride.

[chromium-reviews, 2016-04-20 01:52:21]

On Tue, Apr 19, 2016 at 6:41 PM, Robert Kroeger <rjkroege@chromium.org>
wrote:

>
>
> On Tuesday, April 19, 2016, Dana Jansens <danakj@google.com> wrote:
>
>> GLHelper isn't used by display compositor, it's used by reflector and
>> screenshots and stuff.
>>
>
> Not entirely so. Parts are used by c/b/c::BufferQueue which is (in
> essence) a delegate of GpuSurfacelessBrowserCompositorOutputSurface
>

I see. For some uses of it, you'll definitely want to be using it with a
DisplayCompositor (like doing copy requests and acting on the result). I
wonder if there are use cases where you are making textures that aren't
coming from the DisplayCompositor.

I guess they could continue to live together for now, I'm imagining when
DisplayCompositor is in another process, but the browser process code is
using GLHelper from the component, might make it harder to understand
relationships in the code.


>
>
>
>
>>
>> On Tue, Apr 19, 2016 at 6:28 PM, <fsamuel@chromium.org> wrote:
>>
>>> Reviewers: piman
>>> CL: https://codereview.chromium.org/1902463002/
>>>
>>> Description:
>>> Introduce components/display_compositor
>>>
>>> We would like to share BufferQueue, GLHelper and later other parts
>>> of content/browser/compositor in Mus. This CL introduces a new
>>> display_compositor component and moves BufferQueue, GLHelper and
>>> friends to components/display_compositor.
>>>
>>> BUG=601867
>>> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>>>
>>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>>
>>> Affected files (+597, -6548 lines):
>>> M .gn
>>> M BUILD.gn
>>> M build/gn_migration.gypi
>>> M cc/cc_tests.gyp
>>> M components/components.gyp
>>> A components/display_compositor.gypi
>>> A components/display_compositor/BUILD.gn
>>> A components/display_compositor/DEPS
>>> A + components/display_compositor/OWNERS
>>> A + components/display_compositor/buffer_queue.h
>>> A + components/display_compositor/buffer_queue.cc
>>> A + components/display_compositor/buffer_queue_unittest.cc
>>> A components/display_compositor/display_compositor_export.h
>>> A components/display_compositor/display_compositor_test_suite.h
>>> A + components/display_compositor/display_compositor_test_suite.cc
>>> A + components/display_compositor/gl_helper.h
>>> A + components/display_compositor/gl_helper.cc
>>> A + components/display_compositor/gl_helper_benchmark.cc
>>> A + components/display_compositor/gl_helper_readback_support.h
>>> A + components/display_compositor/gl_helper_readback_support.cc
>>> A + components/display_compositor/gl_helper_scaling.h
>>> A + components/display_compositor/gl_helper_scaling.cc
>>> A + components/display_compositor/gl_helper_unittest.cc
>>> A + components/display_compositor/run_all_unittests.cc
>>> A + components/display_compositor/yuv_readback_unittest.cc
>>> M content/browser/BUILD.gn
>>> M content/browser/compositor/DEPS
>>> D content/browser/compositor/buffer_queue.h
>>> D content/browser/compositor/buffer_queue.cc
>>> D content/browser/compositor/buffer_queue_unittest.cc
>>> D content/browser/compositor/gl_helper.h
>>> D content/browser/compositor/gl_helper.cc
>>> D content/browser/compositor/gl_helper_benchmark.cc
>>> D content/browser/compositor/gl_helper_readback_support.h
>>> D content/browser/compositor/gl_helper_readback_support.cc
>>> D content/browser/compositor/gl_helper_scaling.h
>>> D content/browser/compositor/gl_helper_scaling.cc
>>> D content/browser/compositor/gl_helper_unittest.cc
>>> M content/browser/compositor/gpu_process_transport_factory.h
>>> M content/browser/compositor/gpu_process_transport_factory.cc
>>> M
>>>
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
>>> M
>>>
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
>>> M content/browser/compositor/image_transport_factory.h
>>> M content/browser/compositor/image_transport_factory_browsertest.cc
>>> M content/browser/compositor/owned_mailbox.h
>>> M content/browser/compositor/owned_mailbox.cc
>>> M content/browser/compositor/reflector_texture.h
>>> M content/browser/compositor/reflector_texture.cc
>>> M content/browser/compositor/surface_utils.cc
>>> M content/browser/compositor/test/no_transport_image_transport_factory.h
>>> M content/browser/compositor/test/no_transport_image_transport_factory.cc
>>> D content/browser/compositor/yuv_readback_unittest.cc
>>> M content/browser/media/capture/DEPS
>>> M content/browser/media/capture/aura_window_capture_machine.h
>>> M content/browser/media/capture/aura_window_capture_machine.cc
>>> M content/browser/renderer_host/DEPS
>>> M content/browser/renderer_host/compositor_impl_android.cc
>>> M content/browser/renderer_host/delegated_frame_host.h
>>> M content/browser/renderer_host/delegated_frame_host.cc
>>> M
>>> content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
>>> M content/browser/renderer_host/media/video_capture_controller.cc
>>> M content/browser/renderer_host/render_widget_host_view_android.cc
>>> M content/browser/renderer_host/render_widget_host_view_aura.cc
>>> M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
>>> M content/content_browser.gypi
>>> M content/content_tests.gypi
>>> M content/test/BUILD.gn
>>> M testing/buildbot/chromium.fyi.json
>>> M testing/buildbot/gn_isolate_map.pyl
>>>
>>>
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2016-04-20 03:37:50]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 03:37:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/270001

[commit-bot: I haz the power, 2016-04-20 03:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 03:46:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Fady Samuel, 2016-04-20 03:57:38]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 03:57:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/290001

[commit-bot: I haz the power, 2016-04-20 04:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 04:11:51]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-20 14:00:02]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 14:00:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/310001

[commit-bot: I haz the power, 2016-04-20 14:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:07:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-20 14:49:52]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 14:50:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/310001

[commit-bot: I haz the power, 2016-04-20 14:57:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:57:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-20 15:01:32]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org, xhwang@chromium.org

[Fady Samuel, 2016-04-20 15:01:34]

Adding more reviewers for DEPS:

sky@ for ui/ and third_party/ deps in display_compositor
xhwang@ for media/ dep
piman@ (already reviewer) for cc/ and gpu/ deps.

[xhwang, 2016-04-20 16:20:48]

media/ dep lgtm with one comment.

https://chromiumcodereview.appspot.com/1902463002/diff/310001/components/disp...
File components/display_compositor/DEPS (right):

https://chromiumcodereview.appspot.com/1902463002/diff/310001/components/disp...
components/display_compositor/DEPS:7: "+media/base",
Please add a comment that this is used for test only.

[xhwang, 2016-04-20 16:24:58]

https://chromiumcodereview.appspot.com/1902463002/diff/310001/components/disp...
File components/display_compositor/DEPS (right):

https://chromiumcodereview.appspot.com/1902463002/diff/310001/components/disp...
components/display_compositor/DEPS:7: "+media/base",
On 2016/04/20 16:20:47, xhwang wrote:
> Please add a comment that this is used for test only.

Even better, can you use a specific_include_rules in the DEPS to make sure
media/ is only used by tests?

https://code.google.com/p/chromium/codesearch#chromium/src/cc/base/DEPS&l=8

[Fady Samuel, 2016-04-20 17:37:01]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 17:37:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/330001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/330001

[Fady Samuel, 2016-04-20 17:38:28]

PTAL

piman@ for overall
sky@ for ui/ and third_party/ deps

Thanks!

https://chromiumcodereview.appspot.com/1902463002/diff/310001/components/disp...
File components/display_compositor/DEPS (right):

https://chromiumcodereview.appspot.com/1902463002/diff/310001/components/disp...
components/display_compositor/DEPS:7: "+media/base",
On 2016/04/20 16:24:57, xhwang wrote:
> On 2016/04/20 16:20:47, xhwang wrote:
> > Please add a comment that this is used for test only.
> 
> Even better, can you use a specific_include_rules in the DEPS to make sure
> media/ is only used by tests?
> 
> https://code.google.com/p/chromium/codesearch#chromium/src/cc/base/DEPS&l=8

Done.

[xhwang, 2016-04-20 17:39:43]

Thanks! media/ dep lgtm++

[commit-bot: I haz the power, 2016-04-20 17:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 17:45:59]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2016-04-20 18:26:42]

new deps LGTM

[piman, 2016-04-20 20:07:22]

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/BUILD.gn (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/BUILD.gn:40: "gl_helper_benchmark.cc",
Have you checked how long this runs for? It's not really a unit test (it doesn't
really have a way to fail - it just prints timing information). If it takes more
than, say, 10s, let's keep it in a separate binary, to avoid taking time on
bots.

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/OWNERS (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/OWNERS:3: ccameron@chromium.org
Could you add me here?

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/buffer_queue.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/buffer_queue.cc:119: // http://crbug.com/524624
nit: indent was correct before.

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/gl_helper_benchmark.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/gl_helper_benchmark.cc:53: class GLHelperTest :
public testing::Test {
nit: this should probably be in the anonymous namespace too, to avoid ODR
issues.

https://codereview.chromium.org/1902463002/diff/330001/content/content_browse...
File content/content_browser.gypi (left):

https://codereview.chromium.org/1902463002/diff/330001/content/content_browse...
content/content_browser.gypi:551: # needed on all platforms.
nit: keep the note, because that's still true of surface_utils.*

[Fady Samuel, 2016-04-20 21:38:54]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 21:39:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/350001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/350001

[Fady Samuel, 2016-04-20 21:41:11]

PTAL Antoine, I addressed all but one of your comments.

In particular, it looks like I can't easily make GLHelperTest in
gl_helper_benchmark in the anonymous namespace because GLHelperScaling::ScaleOp
is a private class. I can make it public. I don't think GLHelperScaling can
befriend a class in an anonymous namespace. WDYT? Thanks

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/BUILD.gn (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/BUILD.gn:40: "gl_helper_benchmark.cc",
On 2016/04/20 20:07:22, piman wrote:
> Have you checked how long this runs for? It's not really a unit test (it
doesn't
> really have a way to fail - it just prints timing information). If it takes
more
> than, say, 10s, let's keep it in a separate binary, to avoid taking time on
> bots.

Looks like 30s. Made it a separate binary: display_compositor_benchmark

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/OWNERS (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/OWNERS:3: ccameron@chromium.org
On 2016/04/20 20:07:22, piman wrote:
> Could you add me here?

Done.

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/buffer_queue.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/buffer_queue.cc:119: // http://crbug.com/524624
On 2016/04/20 20:07:22, piman wrote:
> nit: indent was correct before.

Hmm, seems like a git cl format bug. Done.

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/gl_helper_benchmark.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/gl_helper_benchmark.cc:53: class GLHelperTest :
public testing::Test {
On 2016/04/20 20:07:22, piman wrote:
> nit: this should probably be in the anonymous namespace too, to avoid ODR
> issues.

This turns out to be hard because GLHelperScaling::ScaleOp is private and
GLHelperTest is a friend class. I could make it public? WDYT?

https://codereview.chromium.org/1902463002/diff/330001/content/content_browse...
File content/content_browser.gypi (left):

https://codereview.chromium.org/1902463002/diff/330001/content/content_browse...
content/content_browser.gypi:551: # needed on all platforms.
On 2016/04/20 20:07:22, piman wrote:
> nit: keep the note, because that's still true of surface_utils.*

Done.

[danakj, 2016-04-20 21:44:12]

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/buffer_queue.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/buffer_queue.cc:119: // http://crbug.com/524624
On 2016/04/20 21:41:11, Fady Samuel wrote:
> On 2016/04/20 20:07:22, piman wrote:
> > nit: indent was correct before.
> 
> Hmm, seems like a git cl format bug. Done.

clang-format will use the indent of the #if.

Move the comment onto the DCHECK instead.

[Fady Samuel, 2016-04-20 21:49:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-04-20 21:49:33]

w00t! That makes git cl format happy! Thanks! PTAL!

[commit-bot: I haz the power, 2016-04-20 21:49:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/370001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/370001

[piman, 2016-04-20 21:51:22]

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/gl_helper_benchmark.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/gl_helper_benchmark.cc:53: class GLHelperTest :
public testing::Test {
On 2016/04/20 21:41:11, Fady Samuel wrote:
> On 2016/04/20 20:07:22, piman wrote:
> > nit: this should probably be in the anonymous namespace too, to avoid ODR
> > issues.
> 
> This turns out to be hard because GLHelperScaling::ScaleOp is private and
> GLHelperTest is a friend class. I could make it public? WDYT? 

I checked, and we actually do have ODR issues - both gl_helper_unittest.cc and
gl_helper_benchmark.cc define GLHelperTest. Scary.

I guess we get away with it because they're in separate executables.

Do you mind renaming one of them (e.g. this one to GLHelperBenchmark) for
sanity?

[commit-bot: I haz the power, 2016-04-20 21:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:59:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-20 22:12:15]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-04-20 22:12:59]

PTAL Antoine! Thanks! :)

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
File components/display_compositor/gl_helper_benchmark.cc (right):

https://codereview.chromium.org/1902463002/diff/330001/components/display_com...
components/display_compositor/gl_helper_benchmark.cc:53: class GLHelperTest :
public testing::Test {
On 2016/04/20 21:51:22, piman wrote:
> On 2016/04/20 21:41:11, Fady Samuel wrote:
> > On 2016/04/20 20:07:22, piman wrote:
> > > nit: this should probably be in the anonymous namespace too, to avoid ODR
> > > issues.
> > 
> > This turns out to be hard because GLHelperScaling::ScaleOp is private and
> > GLHelperTest is a friend class. I could make it public? WDYT? 
> 
> I checked, and we actually do have ODR issues - both gl_helper_unittest.cc and
> gl_helper_benchmark.cc define GLHelperTest. Scary.
> 
> I guess we get away with it because they're in separate executables.
> 
> Do you mind renaming one of them (e.g. this one to GLHelperBenchmark) for
> sanity?

Done.

[commit-bot: I haz the power, 2016-04-20 22:13:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/390001

[piman, 2016-04-20 22:15:23]

lgtm

[commit-bot: I haz the power, 2016-04-20 23:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 23:37:12]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-04-20 23:41:06]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-20 23:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1902463002/#ps390001
(title: "GLHelperTest => GLHelperBenchmark in gl_helper_benchmark.cc")

[commit-bot: I haz the power, 2016-04-20 23:42:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/390001

[commit-bot: I haz the power, 2016-04-20 23:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 23:56:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-21 00:29:49]

fsamuel@chromium.org changed reviewers:
+ ben@chromium.org

[Fady Samuel, 2016-04-21 00:29:51]

+ben@ (TBR'ing) for:

 .gn
 BUILD.gn
 build/gn_migration.gypi
 components/components.gyp
 components/display_compositor.gypi

[Fady Samuel, 2016-04-21 00:30:21]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-04-21 00:30:33]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-04-21 00:32:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/390001

[commit-bot: I haz the power, 2016-04-21 00:39:24]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-21 00:39:27]

Committed patchset #21 (id:390001)

[tkent, 2016-04-21 01:48:55]

A revert of this CL (patchset #21 id:390001) has been created in
https://codereview.chromium.org/1905863002/ by tkent@chromium.org.

The reason for reverting is: Broke Windows x64 build.
c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142):
error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss
of data

https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...
.

[Fady Samuel, 2016-04-21 02:08:18]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-04-21 02:09:14]

Relanding. The issue was I was not suppressing size_t conversion warnings in
unittest / benchmark targets. Fixed that.

[Fady Samuel, 2016-04-21 02:09:30]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-21 02:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
xhwang@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1902463002/#ps410001
(title: "Suppress size_t warnings on all display_compositor targets")

[commit-bot: I haz the power, 2016-04-21 02:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/410001

[Fady Samuel, 2016-04-21 02:31:53]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
==========

[Fady Samuel, 2016-04-21 02:32:17]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-04-21 02:32:18]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-04-21 02:32:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/410001

[tkent, 2016-04-21 02:33:30]

Let me add NOTREECHECKS=true because I think this will fix broken bots.

[tkent, 2016-04-21 02:33:43]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
==========

[tkent, 2016-04-21 02:38:28]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-04-21 02:38:36]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-04-21 02:39:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/410001

[commit-bot: I haz the power, 2016-04-21 02:45:03]

Committed patchset #22 (id:410001)

[Nico, 2016-04-21 13:58:17]

A revert of this CL (patchset #22 id:410001) has been created in
https://codereview.chromium.org/1904773004/ by thakis@chromium.org.

The reason for reverting is: This added the new test to some FYI bots (but
nowhere else?) and claimed that the binary can run on swarming but it doesn't
add a _run target or an isolate file to actually run it on swarming. As a
consequence, the FYI bots this added the test to that still use gyp now all fail
their "isolate tests" step. Example:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4976.

[Fady Samuel, 2016-04-21 15:04:34]

On 2016/04/21 13:58:17, Nico wrote:
> A revert of this CL (patchset #22 id:410001) has been created in
> https://codereview.chromium.org/1904773004/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: This added the new test to some FYI bots (but
> nowhere else?) and claimed that the binary can run on swarming but it doesn't
> add a _run target or an isolate file to actually run it on swarming. As a
> consequence, the FYI bots this added the test to that still use gyp now all
fail
> their "isolate tests" step. Example:
> https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4976.

Argh, I foolishly and incorrectly cargo-culted adding the test to the bots and
neglected to get feedback on correctness. Apologies. I think I might pull out
the bot changes into a separate CL to have a discussion about how to properly
add new test binaries to bots. Thanks!

[Fady Samuel, 2016-04-21 18:39:06]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
==========

[Fady Samuel, 2016-04-21 18:39:26]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-21 18:39:27]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
xhwang@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1902463002/#ps430001
(title: "Remove bot changes. Will do in a separate CL")

[commit-bot: I haz the power, 2016-04-21 18:40:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902463002/430001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902463002/430001

[commit-bot: I haz the power, 2016-04-21 18:47:20]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
==========

[commit-bot: I haz the power, 2016-04-21 18:47:23]

Committed patchset #23 (id:430001)

[commit-bot: I haz the power, 2016-04-22 19:29:25]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a
Cr-Commit-Position: refs/heads/master@{#388641}
==========

[commit-bot: I haz the power, 2016-04-22 19:29:29]

Patchset 23 (id:??) landed as
https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a
Cr-Commit-Position: refs/heads/master@{#388641}

[commit-bot: I haz the power, 2016-04-22 19:30:21]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ea767b706b88fbeb77655c2193d593dfef54660a
Cr-Commit-Position: refs/heads/master@{#388641}
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true

Committed: https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee
Cr-Commit-Position: refs/heads/master@{#388662}
==========

[commit-bot: I haz the power, 2016-04-22 19:30:24]

Patchset 23 (id:??) landed as
https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee
Cr-Commit-Position: refs/heads/master@{#388662}

[commit-bot: I haz the power, 2016-04-22 19:36:45]

Description was changed from

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true

Committed: https://crrev.com/ec03489356fa45add604aaca28f277a0c9f83dee
Cr-Commit-Position: refs/heads/master@{#388662}
==========

to

==========
Introduce components/display_compositor

We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.

BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true

Committed: https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa
Cr-Commit-Position: refs/heads/master@{#388829}
==========

[commit-bot: I haz the power, 2016-04-22 19:36:48]

Patchset 23 (id:??) landed as
https://crrev.com/540b8c11b0418e42e79fa27b84ac4f3c0f7770fa
Cr-Commit-Position: refs/heads/master@{#388829}