Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901593006: [DevTools] Remove InspectorAgent::discardAgent. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, haraken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1899933003
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove InspectorAgent::discardAgent. BUG=590878 Committed: https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a Cr-Commit-Position: refs/heads/master@{#388670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 3 chunks +12 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 1899933003 Patch 80001

Dependent Patchsets:

Issue 1903953002 Patch 1

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-04-20 21:15:28 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-21 01:21:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901593006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901593006/1
4 years, 8 months ago (2016-04-21 01:25:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 03:05:02 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:30:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9c51d2bdec6a00f959f4ad5be7173761532dee0a
Cr-Commit-Position: refs/heads/master@{#388670}

Powered by Google App Engine
This is Rietveld 408576698