[DevTools] Introduce InspectorSession.

[DevTools] Introduce InspectorSession.

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
Committed: https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8
Cr-Commit-Position: refs/heads/master@{#388569}

[dgozman, 2016-04-19 21:29:13]

Description was changed from

==========
[DevTools] Introduce InspectorConnection.

Connection manages agents list, does bookkeeping and handles messages.
Connection only exists while client is attached.
There will be one connection per client in multi-client scenario.

BUG=590878
==========

to

==========
[DevTools] Introduce InspectorConnection.

Connection manages agents list, does bookkeeping and handles messages.
Connection only exists while client is attached.
There will be one connection per client in multi-client scenario.

Simplified InspectorAgent interface along the lines.

BUG=590878
==========

[dgozman, 2016-04-19 21:29:24]

Description was changed from

==========
[DevTools] Introduce InspectorConnection.

Connection manages agents list, does bookkeeping and handles messages.
Connection only exists while client is attached.
There will be one connection per client in multi-client scenario.

Simplified InspectorAgent interface along the lines.

BUG=590878
==========

to

==========
[DevTools] Introduce InspectorConnection.

Connection manages agents list, does bookkeeping and handles messages.
Connection only exists while client is attached.
There will be one connection per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
==========

[dgozman, 2016-04-19 21:34:43]

Description was changed from

==========
[DevTools] Introduce InspectorConnection.

Connection manages agents list, does bookkeeping and handles messages.
Connection only exists while client is attached.
There will be one connection per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
==========

to

==========
[DevTools] Introduce InspectorSession.

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
==========

[dgozman, 2016-04-19 21:43:39]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-04-19 21:43:39]

Take a look please.

[dgozman, 2016-04-19 21:43:44]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 21:44:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899933003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899933003/60001

[commit-bot: I haz the power, 2016-04-19 23:04:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 23:04:56]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[pfeldman, 2016-04-20 18:52:21]

lgtm

https://codereview.chromium.org/1899933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h (right):

https://codereview.chromium.org/1899933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:101: void
sendProtocolResponse(int sessionId, int callId,
PassOwnPtr<protocol::DictionaryValue> message) override;
private

[dgozman, 2016-04-20 19:19:52]

https://codereview.chromium.org/1899933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h (right):

https://codereview.chromium.org/1899933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:101: void
sendProtocolResponse(int sessionId, int callId,
PassOwnPtr<protocol::DictionaryValue> message) override;
On 2016/04/20 18:52:21, pfeldman wrote:
> private

Done.

[dgozman, 2016-04-20 19:19:58]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-04-20 19:19:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1899933003/#ps80001
(title: "export, comment")

[commit-bot: I haz the power, 2016-04-20 19:20:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899933003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899933003/80001

[commit-bot: I haz the power, 2016-04-20 20:33:33]

Description was changed from

==========
[DevTools] Introduce InspectorSession.

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
==========

to

==========
[DevTools] Introduce InspectorSession.

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
==========

[commit-bot: I haz the power, 2016-04-20 20:33:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:26:12]

Description was changed from

==========
[DevTools] Introduce InspectorSession.

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878
==========

to

==========
[DevTools] Introduce InspectorSession.

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878

Committed: https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8
Cr-Commit-Position: refs/heads/master@{#388569}
==========

[commit-bot: I haz the power, 2016-04-22 19:26:13]

Patchset 5 (id:??) landed as
https://crrev.com/8d00b5cf8ca521e1edd1c86010e4e09c3a0ee5c8
Cr-Commit-Position: refs/heads/master@{#388569}