Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1903953002: [DevTools] Move from InstrumentingAgents to InstrumentingSessions. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, blink-reviews, dmazzoni, yuzo+watch_chromium.org, haraken, Nate Chapin, tyoshino+watch_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-discard-agent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move from InstrumentingAgents to InstrumentingSessions. InspectorSession now holds auto-generated InstrumentingAgents instance. InspectorInstrumentation fetches InstrumentingSessions from different entities and then calls into agents in each session. This could potentially speed up instrumentation when inspector is not attached: we only have InspectorSession objects when attached, while InstrumentingAgents object was always present before. BUG=590878 Committed: https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd Cr-Commit-Position: refs/heads/master@{#388992}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -187 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core_generated.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 8 chunks +27 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectedFrames.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 1 4 chunks +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 7 chunks +78 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/inspector/InstrumentingAgents.h View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/inspector/InstrumentingSessions.h View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 6 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 9 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Could you please take a look?
4 years, 8 months ago (2016-04-21 00:02:48 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-21 01:24:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903953002/1
4 years, 8 months ago (2016-04-21 03:16:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/125330)
4 years, 8 months ago (2016-04-21 03:29:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903953002/20001
4 years, 8 months ago (2016-04-21 23:55:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 01:14:43 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:43:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/946af3c81704defad704e49046c65e29ccd5f5dd
Cr-Commit-Position: refs/heads/master@{#388992}

Powered by Google App Engine
This is Rietveld 408576698