Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1901353003: [profiler] Remove obsolete CompilationInfo argument. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-27
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Remove obsolete CompilationInfo argument. This removes the CompilationInfo argument from one of the logging functions where it is unused. The long-term goal is to not pass around the CompilationInfo at all. The assumption that the CompilationInfo is available is incompatible with serialized code, where compilation has happened during building time of V8 itself. R=yangguo@chromium.org Committed: https://crrev.com/6f43e1f54480f6da5667b05e6b42605598746003 Cr-Commit-Position: refs/heads/master@{#35705}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -28 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/log.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M src/profiler/cpu-profiler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 2 chunks +1 line, -4 lines 2 comments Download
M src/snapshot/code-serializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-20 11:02:23 UTC) #1
Yang
https://codereview.chromium.org/1901353003/diff/1/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (left): https://codereview.chromium.org/1901353003/diff/1/src/profiler/cpu-profiler.cc#oldcode256 src/profiler/cpu-profiler.cc:256: if (info) { Does removing this break anything? If ...
4 years, 8 months ago (2016-04-21 11:17:16 UTC) #2
Yang
as discussed offline, lgtm.
4 years, 8 months ago (2016-04-21 11:58:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901353003/1
4 years, 8 months ago (2016-04-21 12:33:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 13:16:57 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f43e1f54480f6da5667b05e6b42605598746003
Cr-Commit-Position: refs/heads/master@{#35705}

Powered by Google App Engine
This is Rietveld 408576698