Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 1903723002: [compiler] Remove CompilationInfo::abstract_code accessor. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-26
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove CompilationInfo::abstract_code accessor. In the long run we do not want to rely on compilation results being available on the CompilationInfo. This removes the accessor for the abstract code, which is very inviting to be used outside of compilation pipeline. R=yangguo@chromium.org Committed: https://crrev.com/59d08247c74641b603abde88ed943dabc36096bf Cr-Commit-Position: refs/heads/master@{#35653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M src/compiler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler.cc View 7 chunks +12 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-20 08:39:23 UTC) #1
Yang
On 2016/04/20 08:39:23, Michael Starzinger wrote: lgtm.
4 years, 8 months ago (2016-04-20 08:55:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903723002/1
4 years, 8 months ago (2016-04-20 11:03:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 11:05:59 UTC) #5
nodir1
4 years, 8 months ago (2016-04-22 18:44:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59d08247c74641b603abde88ed943dabc36096bf
Cr-Commit-Position: refs/heads/master@{#35653}

Powered by Google App Engine
This is Rietveld 408576698