Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: src/log.cc

Issue 1901353003: [profiler] Remove obsolete CompilationInfo argument. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-27
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index da935d8af72345ffd7393383b13fcc8b17a96903..3abf442d7f5ad50c2bbba43356b4c069e95c2005 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -180,8 +180,7 @@ void CodeEventLogger::CodeCreateEvent(Logger::LogEventsAndTags tag,
void CodeEventLogger::CodeCreateEvent(Logger::LogEventsAndTags tag,
AbstractCode* code,
- SharedFunctionInfo* shared,
- CompilationInfo* info, Name* name) {
+ SharedFunctionInfo* shared, Name* name) {
name_buffer_->Init(tag);
name_buffer_->AppendBytes(ComputeMarker(shared, code));
name_buffer_->AppendName(name);
@@ -1118,12 +1117,11 @@ void Logger::CodeCreateEvent(LogEventsAndTags tag, AbstractCode* code,
}
void Logger::CodeCreateEvent(LogEventsAndTags tag, AbstractCode* code,
- SharedFunctionInfo* shared, CompilationInfo* info,
- Name* name) {
- PROFILER_LOG(CodeCreateEvent(tag, code, shared, info, name));
+ SharedFunctionInfo* shared, Name* name) {
+ PROFILER_LOG(CodeCreateEvent(tag, code, shared, name));
if (!is_logging_code_events()) return;
- CALL_LISTENERS(CodeCreateEvent(tag, code, shared, info, name));
+ CALL_LISTENERS(CodeCreateEvent(tag, code, shared, name));
if (!FLAG_log_code || !log_->IsEnabled()) return;
if (code == AbstractCode::cast(
@@ -1618,10 +1616,9 @@ void Logger::LogExistingFunction(Handle<SharedFunctionInfo> shared,
*script_name, line_num, column_num));
} else {
// Can't distinguish eval and script here, so always use Script.
- PROFILE(isolate_,
- CodeCreateEvent(
- Logger::ToNativeByScript(Logger::SCRIPT_TAG, *script),
- *code, *shared, NULL, *script_name));
+ PROFILE(isolate_, CodeCreateEvent(Logger::ToNativeByScript(
+ Logger::SCRIPT_TAG, *script),
+ *code, *shared, *script_name));
}
} else {
PROFILE(isolate_,
@@ -1644,9 +1641,8 @@ void Logger::LogExistingFunction(Handle<SharedFunctionInfo> shared,
PROFILE(isolate_, CallbackEvent(*func_name, entry_point));
}
} else {
- PROFILE(isolate_,
- CodeCreateEvent(
- Logger::LAZY_COMPILE_TAG, *code, *shared, NULL, *func_name));
+ PROFILE(isolate_, CodeCreateEvent(Logger::LAZY_COMPILE_TAG, *code, *shared,
+ *func_name));
}
}
« no previous file with comments | « src/log.h ('k') | src/profiler/cpu-profiler.h » ('j') | src/profiler/cpu-profiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698