Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 115643002: Hook up GN official build and branding. (Closed)

Created:
7 years ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
Nico, piman
CC:
chromium-reviews
Visibility:
Public.

Description

Hook up GN official build and branding. This passes the official build and branding flags to the GN build. Currently, this is used to hook up the proper sysroot for compiling on Linux for official builds. The 32-bit branded build does not compile currently due to pending pkgconfig issues. Fix a bug where assertions in the build config would not get reported properly. This was because I forgot to actually throw the error at the toplevel. BUG= R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240918

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 3 chunks +8 lines, -4 lines 0 comments Download
A build/config/linux/sysroot.gni View 1 1 chunk +27 lines, -0 lines 2 comments Download
M build/gyp_chromium View 1 chunk +11 lines, -4 lines 0 comments Download
M tools/gn/loader.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
brettw
7 years ago (2013-12-14 00:25:38 UTC) #1
piman
lgtm
7 years ago (2013-12-14 01:43:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/115643002/10001
7 years ago (2013-12-14 04:19:12 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204013
7 years ago (2013-12-14 05:21:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/115643002/10001
7 years ago (2013-12-14 20:01:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204255
7 years ago (2013-12-14 20:44:58 UTC) #6
brettw
Committed patchset #2 manually as r240918 (presubmit successful).
7 years ago (2013-12-16 17:59:27 UTC) #7
Nico
https://codereview.chromium.org/115643002/diff/10001/build/config/linux/sysroot.gni File build/config/linux/sysroot.gni (right): https://codereview.chromium.org/115643002/diff/10001/build/config/linux/sysroot.gni#newcode23 build/config/linux/sysroot.gni:23: # TODO(brettw) this needs to be configurable somehow. In ...
6 years, 11 months ago (2014-01-01 04:04:24 UTC) #8
brettw
6 years, 11 months ago (2014-01-02 03:53:17 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/115643002/diff/10001/build/config/linux/sysro...
File build/config/linux/sysroot.gni (right):

https://codereview.chromium.org/115643002/diff/10001/build/config/linux/sysro...
build/config/linux/sysroot.gni:23: # TODO(brettw) this needs to be configurable
somehow.
Good point, I'll move this.

Powered by Google App Engine
This is Rietveld 408576698