Move the notification constants to Blink

third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/notifications/NotificationResourcesLoader.h"
 
 #include "platform/weborigin/KURL.h"
+#include "public/platform/modules/notifications/WebNotificationConstants.h"
 #include "public/platform/modules/notifications/WebNotificationData.h"
 #include "public/platform/modules/notifications/WebNotificationResources.h"
 #include "skia/ext/image_operations.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace blink {
 
 namespace {
 
-// TODO(mvanouwerkerk): Get icon dimensions from the embedder.
-
-// The maximum reasonable notification icon size, scaled from dip units to
-// pixels using the largest supported scaling factor.
-static const int kMaxIconSizePx = 320; // 80 dip * 4
-
-// The maximum reasonable badge size, scaled from dip units to pixels using the
-// largest supported scaling factor.
-static const int kMaxBadgeSizePx = 96; // 24 dip * 4
-
-// The maximum reasonable action icon size, scaled from dip units to pixels
-// using the largest supported scaling factor.
-static const int kMaxActionIconSizePx = 128; // 32 dip * 4
-
 // Scales down |image| to fit within |maxSizePx| if its width or height is
 // larger than |maxSizePx| and returns the result. Otherwise does nothing and
 // returns |image| unchanged.
 // TODO(mvanouwerkerk): Explore doing the scaling on a background thread.
 SkBitmap scaleDownIfNeeded(const SkBitmap& image, int maxSizePx)
 {
     if (image.width() > maxSizePx || image.height() > maxSizePx)
         return skia::ImageOperations::Resize(image, skia::ImageOperations::RESIZE_BEST, std::min(image.width(), maxSizePx), std::min(image.height(), maxSizePx));
     return image;
 }
@@ skipping 54 matching lines @@
         return;
     }
 
     NotificationImageLoader* imageLoader = new NotificationImageLoader();
     m_imageLoaders.append(imageLoader);
     imageLoader->start(executionContext, url, imageCallback);
 }
 
 void NotificationResourcesLoader::didLoadIcon(const SkBitmap& image)
 {
-    m_icon = scaleDownIfNeeded(image, kMaxIconSizePx);
+    m_icon = scaleDownIfNeeded(image, kWebNotificationMaxIconSizePx);
     didFinishRequest();
 }
 
 void NotificationResourcesLoader::didLoadBadge(const SkBitmap& image)
 {
-    m_badge = scaleDownIfNeeded(image, kMaxBadgeSizePx);
+    m_badge = scaleDownIfNeeded(image, kWebNotificationMaxBadgeSizePx);
     didFinishRequest();
 }
 
 void NotificationResourcesLoader::didLoadActionIcon(size_t actionIndex, const SkBitmap& image)
 {
     DCHECK_LT(actionIndex, m_actionIcons.size());
 
-    m_actionIcons[actionIndex] = scaleDownIfNeeded(image, kMaxActionIconSizePx);
+    m_actionIcons[actionIndex] = scaleDownIfNeeded(image, kWebNotificationMaxActionIconSizePx);
     didFinishRequest();
 }
 
 void NotificationResourcesLoader::didFinishRequest()
 {
     DCHECK_GT(m_pendingRequestCount, 0);
     m_pendingRequestCount--;
     if (!m_pendingRequestCount) {
         stop();
         (*m_completionCallback)(this);
         // The |this| pointer may have been deleted now.
     }
 }
 
 } // namespace blink