Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1900863004: VM: Remove _leftShiftWithMask32. (Closed)

Created:
4 years, 8 months ago by Florian Schneider
Modified:
4 years, 8 months ago
Reviewers:
regis, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove _leftShiftWithMask32. It was used for the Javascript integer overflow warnings which were already removed from the VM. BUG= R=regis@google.com, srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/1217e539e9fa5419c548b8b044e21d303860a172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -292 lines) Patch
M runtime/lib/bigint.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/lib/integers.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/lib/integers.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/object_patch.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M runtime/vm/ast.h View 2 chunks +0 lines, -31 lines 0 comments Download
M runtime/vm/ast.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/ast_printer.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 8 months ago (2016-04-19 14:56:16 UTC) #2
regis
LGTM I missed that one. Thanks!
4 years, 8 months ago (2016-04-19 16:26:47 UTC) #4
srdjan
lgtm
4 years, 8 months ago (2016-04-19 16:46:52 UTC) #5
Florian Schneider
4 years, 8 months ago (2016-04-19 17:07:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1217e539e9fa5419c548b8b044e21d303860a172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698