Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1900863004: VM: Remove _leftShiftWithMask32. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/jit_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index a4214773d4eded1a2d553d8f84d90b774888dda3..69f7f16a49dfc9bfa4046ba2b1ed65ce8c705f43 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1460,54 +1460,6 @@ void ValueGraphVisitor::VisitBinaryOpNode(BinaryOpNode* node) {
}
-static const String& BinaryOpAndMaskName(BinaryOpNode* node) {
- if (node->kind() == Token::kSHL) {
- return Library::PrivateCoreLibName(Symbols::_leftShiftWithMask32());
- }
- UNIMPLEMENTED();
- return String::ZoneHandle(Thread::Current()->zone(), String::null());
-}
-
-
-// <Expression> :: BinaryOp { kind: Token::Kind
-// left: <Expression>
-// right: <Expression>
-// mask32: constant }
-void EffectGraphVisitor::VisitBinaryOpWithMask32Node(
- BinaryOpWithMask32Node* node) {
- ASSERT((node->kind() != Token::kAND) && (node->kind() != Token::kOR));
- ValueGraphVisitor for_left_value(owner());
- node->left()->Visit(&for_left_value);
- Append(for_left_value);
- PushArgumentInstr* push_left = PushArgument(for_left_value.value());
-
- ValueGraphVisitor for_right_value(owner());
- node->right()->Visit(&for_right_value);
- Append(for_right_value);
- PushArgumentInstr* push_right = PushArgument(for_right_value.value());
-
- Value* mask_value = Bind(new(Z) ConstantInstr(
- Integer::ZoneHandle(Z, Integer::New(node->mask32(), Heap::kOld))));
- PushArgumentInstr* push_mask = PushArgument(mask_value);
-
- ZoneGrowableArray<PushArgumentInstr*>* arguments =
- new(Z) ZoneGrowableArray<PushArgumentInstr*>(3);
- arguments->Add(push_left);
- arguments->Add(push_right);
- // Call to special method 'BinaryOpAndMaskName(node)'.
- arguments->Add(push_mask);
- const intptr_t kNumArgsChecked = 2;
- InstanceCallInstr* call = new(Z) InstanceCallInstr(node->token_pos(),
- BinaryOpAndMaskName(node),
- Token::kILLEGAL,
- arguments,
- Object::null_array(),
- kNumArgsChecked,
- owner()->ic_data_array());
- ReturnDefinition(call);
-}
-
-
void EffectGraphVisitor::BuildTypecheckPushArguments(
TokenPosition token_pos,
PushArgumentInstr** push_instantiator_type_arguments_result) {
« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/jit_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698