Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: runtime/vm/ast.cc

Issue 1900863004: VM: Remove _leftShiftWithMask32. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/ast_printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/ast.h" 5 #include "vm/ast.h"
6 #include "vm/compiler.h" 6 #include "vm/compiler.h"
7 #include "vm/dart_entry.h" 7 #include "vm/dart_entry.h"
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/log.h" 9 #include "vm/log.h"
10 #include "vm/object_store.h" 10 #include "vm/object_store.h"
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 return false; 330 return false;
331 } 331 }
332 } 332 }
333 333
334 334
335 const char* BinaryOpNode::TokenName() const { 335 const char* BinaryOpNode::TokenName() const {
336 return Token::Str(kind_); 336 return Token::Str(kind_);
337 } 337 }
338 338
339 339
340 const char* BinaryOpWithMask32Node::TokenName() const {
341 return Token::Str(kind());
342 }
343
344
345 bool BinaryOpNode::IsPotentiallyConst() const { 340 bool BinaryOpNode::IsPotentiallyConst() const {
346 switch (kind_) { 341 switch (kind_) {
347 case Token::kOR: 342 case Token::kOR:
348 case Token::kAND: 343 case Token::kAND:
349 if (this->left()->IsLiteralNode() && 344 if (this->left()->IsLiteralNode() &&
350 this->left()->AsLiteralNode()->literal().IsNull()) { 345 this->left()->AsLiteralNode()->literal().IsNull()) {
351 return false; 346 return false;
352 } 347 }
353 if (this->right()->IsLiteralNode() && 348 if (this->right()->IsLiteralNode() &&
354 this->right()->AsLiteralNode()->literal().IsNull()) { 349 this->right()->AsLiteralNode()->literal().IsNull()) {
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 if (result.IsError() || result.IsNull()) { 820 if (result.IsError() || result.IsNull()) {
826 // TODO(turnidge): We could get better error messages by returning 821 // TODO(turnidge): We could get better error messages by returning
827 // the Error object directly to the parser. This will involve 822 // the Error object directly to the parser. This will involve
828 // replumbing all of the EvalConstExpr methods. 823 // replumbing all of the EvalConstExpr methods.
829 return NULL; 824 return NULL;
830 } 825 }
831 return &Instance::ZoneHandle(Instance::Cast(result).raw()); 826 return &Instance::ZoneHandle(Instance::Cast(result).raw());
832 } 827 }
833 828
834 } // namespace dart 829 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/ast_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698