Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ObjectVisitor template parameter to RelocInfo::Visit This makes IterateBodyFast work without requiring visitors to inherit from ObjectVisitor. R=ishell@chromium.org Committed: https://crrev.com/19c1a10ba08b91cf90ea17109902a11bd4a0ab3a Cr-Commit-Position: refs/heads/master@{#35604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/assembler-s390-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900843002/1
4 years, 8 months ago (2016-04-18 19:24:22 UTC) #2
Michael Lippautz
This makes IterateBodyFast work without requiring visitors to inherit from ObjectVisitor
4 years, 8 months ago (2016-04-18 19:43:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 19:49:51 UTC) #8
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-19 07:03:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900843002/1
4 years, 8 months ago (2016-04-19 07:04:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 07:06:46 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 07:07:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19c1a10ba08b91cf90ea17109902a11bd4a0ab3a
Cr-Commit-Position: refs/heads/master@{#35604}

Powered by Google App Engine
This is Rietveld 408576698