Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/ppc/assembler-ppc-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/assembler-mips64-inl.h ('k') | src/s390/assembler-s390-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 } else if (IsInternalReferenceEncoded(rmode_)) { 336 } else if (IsInternalReferenceEncoded(rmode_)) {
337 // mov sequence 337 // mov sequence
338 // Currently used only by deserializer, no need to flush. 338 // Currently used only by deserializer, no need to flush.
339 Assembler::set_target_address_at(isolate_, pc_, host_, NULL, 339 Assembler::set_target_address_at(isolate_, pc_, host_, NULL,
340 SKIP_ICACHE_FLUSH); 340 SKIP_ICACHE_FLUSH);
341 } else { 341 } else {
342 Assembler::set_target_address_at(isolate_, pc_, host_, NULL); 342 Assembler::set_target_address_at(isolate_, pc_, host_, NULL);
343 } 343 }
344 } 344 }
345 345
346 346 template <typename ObjectVisitor>
347 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 347 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
348 RelocInfo::Mode mode = rmode(); 348 RelocInfo::Mode mode = rmode();
349 if (mode == RelocInfo::EMBEDDED_OBJECT) { 349 if (mode == RelocInfo::EMBEDDED_OBJECT) {
350 visitor->VisitEmbeddedPointer(this); 350 visitor->VisitEmbeddedPointer(this);
351 } else if (RelocInfo::IsCodeTarget(mode)) { 351 } else if (RelocInfo::IsCodeTarget(mode)) {
352 visitor->VisitCodeTarget(this); 352 visitor->VisitCodeTarget(this);
353 } else if (mode == RelocInfo::CELL) { 353 } else if (mode == RelocInfo::CELL) {
354 visitor->VisitCell(this); 354 visitor->VisitCell(this);
355 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 355 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
356 visitor->VisitExternalReference(this); 356 visitor->VisitExternalReference(this);
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 } 702 }
703 #endif 703 #endif
704 return; 704 return;
705 } 705 }
706 UNREACHABLE(); 706 UNREACHABLE();
707 } 707 }
708 } // namespace internal 708 } // namespace internal
709 } // namespace v8 709 } // namespace v8
710 710
711 #endif // V8_PPC_ASSEMBLER_PPC_INL_H_ 711 #endif // V8_PPC_ASSEMBLER_PPC_INL_H_
OLDNEW
« no previous file with comments | « src/mips64/assembler-mips64-inl.h ('k') | src/s390/assembler-s390-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698