Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/x87/assembler-x87-inl.h

Issue 1900843002: Add ObjectVisitor template parameter to RelocInfo::Visit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 Memory::Address_at(pc_) = NULL; 277 Memory::Address_at(pc_) = NULL;
278 } else if (IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)) { 278 } else if (IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)) {
279 // Effectively write zero into the relocation. 279 // Effectively write zero into the relocation.
280 Assembler::set_target_address_at(isolate_, pc_, host_, 280 Assembler::set_target_address_at(isolate_, pc_, host_,
281 pc_ + sizeof(int32_t)); 281 pc_ + sizeof(int32_t));
282 } else { 282 } else {
283 UNREACHABLE(); 283 UNREACHABLE();
284 } 284 }
285 } 285 }
286 286
287 287 template <typename ObjectVisitor>
288 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 288 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
289 RelocInfo::Mode mode = rmode(); 289 RelocInfo::Mode mode = rmode();
290 if (mode == RelocInfo::EMBEDDED_OBJECT) { 290 if (mode == RelocInfo::EMBEDDED_OBJECT) {
291 visitor->VisitEmbeddedPointer(this); 291 visitor->VisitEmbeddedPointer(this);
292 Assembler::FlushICache(isolate, pc_, sizeof(Address)); 292 Assembler::FlushICache(isolate, pc_, sizeof(Address));
293 } else if (RelocInfo::IsCodeTarget(mode)) { 293 } else if (RelocInfo::IsCodeTarget(mode)) {
294 visitor->VisitCodeTarget(this); 294 visitor->VisitCodeTarget(this);
295 } else if (mode == RelocInfo::CELL) { 295 } else if (mode == RelocInfo::CELL) {
296 visitor->VisitCell(this); 296 visitor->VisitCell(this);
297 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) { 297 } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 568
569 Operand::Operand(Immediate imm) { 569 Operand::Operand(Immediate imm) {
570 // [disp/r] 570 // [disp/r]
571 set_modrm(0, ebp); 571 set_modrm(0, ebp);
572 set_dispr(imm.x_, imm.rmode_); 572 set_dispr(imm.x_, imm.rmode_);
573 } 573 }
574 } // namespace internal 574 } // namespace internal
575 } // namespace v8 575 } // namespace v8
576 576
577 #endif // V8_X87_ASSEMBLER_X87_INL_H_ 577 #endif // V8_X87_ASSEMBLER_X87_INL_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698