Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.h

Issue 1899933003: [DevTools] Introduce InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: export, comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
index f49868239f86d28eb88804695f6b0f61b4a34029..95dc8a4aeb077a71144b9b6f3d457dacf392ceb9 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
@@ -31,10 +31,9 @@
#ifndef WorkerInspectorController_h
#define WorkerInspectorController_h
-#include "core/inspector/InspectorBaseAgent.h"
#include "core/inspector/InspectorRuntimeAgent.h"
+#include "core/inspector/InspectorSession.h"
#include "core/inspector/InspectorTaskRunner.h"
-#include "platform/inspector_protocol/FrontendChannel.h"
#include "wtf/Allocator.h"
#include "wtf/Forward.h"
#include "wtf/Noncopyable.h"
@@ -55,7 +54,7 @@ class Frontend;
class FrontendChannel;
}
-class WorkerInspectorController final : public GarbageCollectedFinalized<WorkerInspectorController>, public InspectorRuntimeAgent::Client, public protocol::FrontendChannel {
+class WorkerInspectorController final : public GarbageCollectedFinalized<WorkerInspectorController>, public InspectorRuntimeAgent::Client, public InspectorSession::Client {
WTF_MAKE_NONCOPYABLE(WorkerInspectorController);
public:
static WorkerInspectorController* create(WorkerGlobalScope*);
@@ -72,24 +71,17 @@ public:
private:
WorkerInspectorController(WorkerGlobalScope*, WorkerThreadDebugger*);
- void initializeAgents();
- void destroyAgents();
-
// InspectorRuntimeAgent::Client implementation.
void resumeStartup() override;
- // protocol::FrontendChannel implementation.
- void sendProtocolResponse(int sessionId, int callId, PassOwnPtr<protocol::DictionaryValue> message) override;
- void sendProtocolNotification(PassOwnPtr<protocol::DictionaryValue> message) override;
- void flush() override;
+ // InspectorSession::Client implementation.
+ void sendProtocolMessage(int sessionId, int callId, const String& response, const String& state) override;
WorkerThreadDebugger* m_debugger;
Member<WorkerGlobalScope> m_workerGlobalScope;
Member<InstrumentingAgents> m_instrumentingAgents;
- InspectorAgentRegistry m_agents;
OwnPtr<V8InspectorSession> m_v8Session;
- OwnPtr<protocol::Frontend> m_frontend;
- OwnPtr<protocol::Dispatcher> m_backendDispatcher;
+ Member<InspectorSession> m_session;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698