MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Modifying 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI event instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
Committed: https://crrev.com/44197c803294b7dbe668672c31fc01be76934961
Cr-Commit-Position: refs/heads/master@{#388129}

[dpapad, 2016-04-18 21:21:46]

Description was changed from

==========
MD Settings: Clear Browsing Data dialog, use proxy pattern, WIP.


BUG=
==========

to

==========
MD Settings: Clear Browsing Data dialog, use proxy pattern, WIP.


BUG=601208
==========

[dpapad, 2016-04-18 21:23:21]

Description was changed from

==========
MD Settings: Clear Browsing Data dialog, use proxy pattern, WIP.


BUG=601208
==========

to

==========
MD Settings: Clear Browsing Data dialog, use browser proxy pattern, WIP.

Also
 - Converting 'performClearBrowserData' to return a Promise.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

[dpapad, 2016-04-18 21:23:46]

Description was changed from

==========
MD Settings: Clear Browsing Data dialog, use browser proxy pattern, WIP.

Also
 - Converting 'performClearBrowserData' to return a Promise.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

to

==========
MD Settings: Clear Browsing Data dialog, use browser proxy pattern, WIP.

Also
 - Converting 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI events instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

[dpapad, 2016-04-18 22:24:09]

Description was changed from

==========
MD Settings: Clear Browsing Data dialog, use browser proxy pattern, WIP.

Also
 - Converting 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI events instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

to

==========
MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Converting 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI events instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

[dpapad, 2016-04-18 22:31:50]

Description was changed from

==========
MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Converting 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI events instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

to

==========
MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Modifying 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI event instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

[dpapad, 2016-04-18 22:51:27]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2016-04-18 22:51:27]

FYI, I am planning to add the spinner, and the disable/enable buttons logic in
follow up CL.

[dschuyler, 2016-04-18 23:19:08]

https://codereview.chromium.org/1899853004/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1899853004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:59:
on-tap="onCancelTap_"></paper-button>
Does switching to an on-tap add something over
dialog-dismiss?

[dpapad, 2016-04-18 23:36:12]

https://codereview.chromium.org/1899853004/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1899853004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:59:
on-tap="onCancelTap_"></paper-button>
On 2016/04/18 at 23:19:08, dschuyler wrote:
> Does switching to an on-tap add something over
> dialog-dismiss?

Reverted. For the "cancel" button dialog-dismiss seems less code, so no benefit
of adding an on-tap handler.

[tommycli, 2016-04-18 23:50:12]

lgtm with nits

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.html
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.html:1:
<script
src="chrome://md-settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js"></script>
nit: I think this should also import the cr.html file.

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js:16:
* @return {!Promise} A promise indicating that clearing data has completed.
nit (optional) "promise resolved when the data clearing has completed"? or
something like that

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:7:
* delete browsing data that has been cached by Chromium.
nit: rephrase to make clear that it also has the "OK" button to actually do it?
(Rather than just providing options)

[dpapad, 2016-04-19 00:02:31]

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.html
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.html:1:
<script
src="chrome://md-settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js"></script>
On 2016/04/18 at 23:50:11, tommycli wrote:
> nit: I think this should also import the cr.html file.

Done.

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js:16:
* @return {!Promise} A promise indicating that clearing data has completed.
On 2016/04/18 at 23:50:11, tommycli wrote:
> nit (optional) "promise resolved when the data clearing has completed"? or
something like that

Done.

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:7:
* delete browsing data that has been cached by Chromium.
On 2016/04/18 at 23:50:12, tommycli wrote:
> nit: rephrase to make clear that it also has the "OK" button to actually do
it? (Rather than just providing options)

Rephrased, I think it is clearer now, let me know if still unclear. BTW, there
is no "OK" button. Instead there is a "Clear Browsing Data" button.

[tommycli, 2016-04-19 00:04:35]

sounds good! Still lgtm

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1899853004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:7:
* delete browsing data that has been cached by Chromium.
On 2016/04/19 00:02:31, dpapad wrote:
> On 2016/04/18 at 23:50:12, tommycli wrote:
> > nit: rephrase to make clear that it also has the "OK" button to actually do
> it? (Rather than just providing options)
> 
> Rephrased, I think it is clearer now, let me know if still unclear. BTW, there
> is no "OK" button. Instead there is a "Clear Browsing Data" button.

perfect

[dpapad, 2016-04-19 00:14:06]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-04-19 00:14:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899853004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899853004/80001

[commit-bot: I haz the power, 2016-04-19 03:48:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-19 03:51:14]

Description was changed from

==========
MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Modifying 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI event instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208
==========

to

==========
MD Settings: Clear Browsing Data dialog, dismiss when clearing is done.

 - Using browser proxy pattern.
 - Modifying 'performClearBrowserData' to return a Promise.
 - Stop calling JS function by name, use WebUI event instead.
 - Adding tests.

This is in preparation of showing a spinner while clearing is in progress.

BUG=601208

Committed: https://crrev.com/44197c803294b7dbe668672c31fc01be76934961
Cr-Commit-Position: refs/heads/master@{#388129}
==========

[commit-bot: I haz the power, 2016-04-19 03:51:15]

Patchset 5 (id:??) landed as
https://crrev.com/44197c803294b7dbe668672c31fc01be76934961
Cr-Commit-Position: refs/heads/master@{#388129}