Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5251)

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

Issue 1899853004: MD Settings: Clear Browsing Data dialog, dismiss when clearing is done. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
index 39248a3cc09bc3728bf95b3f38fc04d397f152bc..905909473dd33d7ec6731efd8435a7661ef27fd2 100644
--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
@@ -33,8 +33,8 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,
void RegisterMessages() override;
private:
- // Javascript callback to start clearing data.
- void HandleClearBrowserData(const base::ListValue* value);
+ // Clears browsing data, called by Javascript.
+ void HandleClearBrowsingData(const base::ListValue* value);
// BrowsingDataRemover::Observer implementation.
// Re-enables clear button once all requested data has been removed.
@@ -46,6 +46,10 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,
// If non-null it means removal is in progress.
BrowsingDataRemover* remover_;
+ // The WebUI callback ID of the last performClearBrowserData request. There
+ // can only be one such request in-flight.
+ std::string webui_callback_id_;
+
// Keeps track of whether clearing LSO data is supported.
BooleanPrefMember clear_plugin_lso_data_enabled_;

Powered by Google App Engine
This is Rietveld 408576698