Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5952)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

Issue 1899853004: MD Settings: Clear Browsing Data dialog, dismiss when clearing is done. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
index 0d9f4de1dd69c1f66b412055c4d332ad99500197..b6b045dd19967946b705b99c356b95eba3719a98 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
@@ -3,21 +3,14 @@
// found in the LICENSE file.
/**
- * @fileoverview
- * 'settings-clear-browsing-data-page' provides options to delete browsing
- * data that has been cached by chromium.
- *
- * Example:
- *
- * <iron-animated-pages>
- * <settings-clear-browsing-data-page prefs="{{prefs}}">
- * </settings-clear-browsing-data-page>
- * ... other pages ...
- * </iron-animated-pages>
+ * @fileoverview 'settings-clear-browsing-data-dialog' allows the user to delete
+ * browsing data that has been cached by Chromium.
*/
Polymer({
is: 'settings-clear-browsing-data-dialog',
+ behaviors: [WebUIListenerBehavior],
+
properties: {
/**
* Preferences state.
@@ -28,14 +21,6 @@ Polymer({
},
/**
- * The current active route.
- */
- currentRoute: {
- type: Object,
- notify: true,
- },
-
- /**
* List of options for the dropdown menu.
* @private {!DropdownMenuOptionList>}
*/
@@ -52,37 +37,24 @@ Polymer({
},
},
+ /** @private {!settings.ClearBrowsingDataBrowserProxy} */
+ browserProxy_: null,
+
+ /** @override */
ready: function() {
this.$.clearFrom.menuOptions = this.clearFromOptions_;
- },
-
- attached: function() {
- var self = this;
- cr.define('SettingsClearBrowserData', function() {
- return {
- doneClearing: function() {
- return self.doneClearing_.apply(self, arguments);
- },
- setAllowDeletingHistory: function() {
- return self.setAllowDeletingHistory_.apply(self, arguments);
- },
- };
- });
- },
-
- /** @private */
- doneClearing_: function() {
- // TODO(dschuyler): inform the user on whether clearing data was successful.
+ this.addWebUIListener(
+ 'browsing-history-pref-changed',
+ this.setAllowDeletingHistory_.bind(this));
+ this.browserProxy_ =
+ settings.ClearBrowsingDataBrowserProxyImpl.getInstance();
},
/**
- * @private
* @param {boolean} allowed Whether the user is allowed to delete histories.
+ * @private
*/
setAllowDeletingHistory_: function(allowed) {
- // This is called from c++, protect against poor timing.
- if (!this.$)
- return;
this.$.browsingCheckbox.disabled = !allowed;
this.$.downloadCheckbox.disabled = !allowed;
if (!allowed) {
@@ -95,12 +67,12 @@ Polymer({
this.$.dialog.open();
},
- /**
- * @param {!Event} event Tells us whether to perform an action or cancel.
- * @private
- */
- onDialogClosed_: function(event) {
- if (event.detail.confirmed)
- chrome.send('performClearBrowserData');
+ /** @private */
+ onClearBrowsingDataTap_: function() {
+ // TODO(dpapad): Show spinner, disable buttons here.
+ this.browserProxy_.clearBrowsingData().then(function() {
+ // TODO(dpapad): Hide spinner, re-enable buttons here.
+ this.$.dialog.close();
+ }.bind(this));
},
});

Powered by Google App Engine
This is Rietveld 408576698