Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 189963005: Revert "Handle non-power-of-2 divisors in division-like operations", "A64 tweaks for division-like … (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Revert "Handle non-power-of-2 divisors in division-like operations", "A64 tweaks for division-like operations." and "Windows build fix.". This reverts commit 19719, 19720 and 19721 because mozilla/ecma/Date/15.9.3.1-1 fails (in release mode only?). TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -939 lines) Patch
M src/a64/lithium-a64.h View 6 chunks +0 lines, -65 lines 0 comments Download
M src/a64/lithium-a64.cc View 9 chunks +12 lines, -72 lines 0 comments Download
M src/a64/lithium-codegen-a64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.cc View 4 chunks +0 lines, -89 lines 0 comments Download
M src/a64/macro-assembler-a64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/arm/lithium-arm.h View 6 chunks +6 lines, -48 lines 0 comments Download
M src/arm/lithium-arm.cc View 7 chunks +38 lines, -58 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +154 lines, -74 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +45 lines, -64 lines 0 comments Download
M src/ia32/lithium-ia32.h View 6 chunks +4 lines, -63 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 5 chunks +9 lines, -71 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/utils.h View 1 chunk +26 lines, -0 lines 0 comments Download
M src/utils.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +27 lines, -65 lines 0 comments Download
M src/x64/lithium-x64.h View 6 chunks +4 lines, -63 lines 0 comments Download
M src/x64/lithium-x64.cc View 5 chunks +7 lines, -68 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
Committed patchset #1 manually as r19722 (tree was closed).
6 years, 9 months ago (2014-03-07 13:12:16 UTC) #1
titzer
6 years, 9 months ago (2014-03-07 14:51:14 UTC) #2
Message was sent while issue was closed.
On 2014/03/07 13:12:16, Sven Panne wrote:
> Committed patchset #1 manually as r19722 (tree was closed).

Could you include some mjsunit tests for this optimization when you land this
again? (e.g. various dividend / divisor combinations). It is quite a tricky
thing and seems like better test coverage would help us get some confidence.

Powered by Google App Engine
This is Rietveld 408576698