Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/arm/lithium-arm.h

Issue 189963005: Revert "Handle non-power-of-2 divisors in division-like operations", "A64 tweaks for division-like … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/macro-assembler-a64.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/lithium-arm.h
diff --git a/src/arm/lithium-arm.h b/src/arm/lithium-arm.h
index 7e2607d02c8dc6f2ea689cc63c00290f12ea628f..6217f5419f8c40b653dcf39e1005cf7644636af2 100644
--- a/src/arm/lithium-arm.h
+++ b/src/arm/lithium-arm.h
@@ -85,7 +85,6 @@ class LCodeGen;
V(DebugBreak) \
V(DeclareGlobals) \
V(Deoptimize) \
- V(DivByConstI) \
V(DivByPowerOf2I) \
V(DivI) \
V(DoubleToI) \
@@ -136,7 +135,6 @@ class LCodeGen;
V(MathPowHalf) \
V(MathRound) \
V(MathSqrt) \
- V(ModByConstI) \
V(ModByPowerOf2I) \
V(ModI) \
V(MulI) \
@@ -638,24 +636,6 @@ class LModByPowerOf2I V8_FINAL : public LTemplateInstruction<1, 1, 0> {
};
-class LModByConstI V8_FINAL : public LTemplateInstruction<1, 1, 0> {
- public:
- LModByConstI(LOperand* dividend, int32_t divisor) {
- inputs_[0] = dividend;
- divisor_ = divisor;
- }
-
- LOperand* dividend() { return inputs_[0]; }
- int32_t divisor() const { return divisor_; }
-
- DECLARE_CONCRETE_INSTRUCTION(ModByConstI, "mod-by-const-i")
- DECLARE_HYDROGEN_ACCESSOR(Mod)
-
- private:
- int32_t divisor_;
-};
-
-
class LModI V8_FINAL : public LTemplateInstruction<1, 2, 2> {
public:
LModI(LOperand* left, LOperand* right, LOperand* temp, LOperand* temp2) {
@@ -693,24 +673,6 @@ class LDivByPowerOf2I V8_FINAL : public LTemplateInstruction<1, 1, 0> {
};
-class LDivByConstI V8_FINAL : public LTemplateInstruction<1, 1, 0> {
- public:
- LDivByConstI(LOperand* dividend, int32_t divisor) {
- inputs_[0] = dividend;
- divisor_ = divisor;
- }
-
- LOperand* dividend() { return inputs_[0]; }
- int32_t divisor() const { return divisor_; }
-
- DECLARE_CONCRETE_INSTRUCTION(DivByConstI, "div-by-const-i")
- DECLARE_HYDROGEN_ACCESSOR(Div)
-
- private:
- int32_t divisor_;
-};
-
-
class LDivI V8_FINAL : public LTemplateInstruction<1, 2, 1> {
public:
LDivI(LOperand* left, LOperand* right, LOperand* temp) {
@@ -749,22 +711,20 @@ class LFlooringDivByPowerOf2I V8_FINAL : public LTemplateInstruction<1, 1, 0> {
};
-class LFlooringDivByConstI V8_FINAL : public LTemplateInstruction<1, 1, 0> {
+class LFlooringDivByConstI V8_FINAL : public LTemplateInstruction<1, 2, 1> {
public:
- LFlooringDivByConstI(LOperand* dividend, int32_t divisor) {
+ LFlooringDivByConstI(LOperand* dividend, LOperand* divisor, LOperand* temp) {
inputs_[0] = dividend;
- divisor_ = divisor;
+ inputs_[1] = divisor;
+ temps_[0] = temp;
}
LOperand* dividend() { return inputs_[0]; }
- int32_t divisor() const { return divisor_; }
- LOperand* temp1() { return temps_[0]; }
+ LOperand* divisor() { return inputs_[1]; }
+ LOperand* temp() { return temps_[0]; }
DECLARE_CONCRETE_INSTRUCTION(FlooringDivByConstI, "flooring-div-by-const-i")
DECLARE_HYDROGEN_ACCESSOR(MathFloorOfDiv)
-
- private:
- int32_t divisor_;
};
@@ -2722,10 +2682,8 @@ class LChunkBuilder V8_FINAL : public LChunkBuilderBase {
LInstruction* DoMathPowHalf(HUnaryMathOperation* instr);
LInstruction* DoMathClz32(HUnaryMathOperation* instr);
LInstruction* DoDivByPowerOf2I(HDiv* instr);
- LInstruction* DoDivByConstI(HDiv* instr);
LInstruction* DoDivI(HBinaryOperation* instr);
LInstruction* DoModByPowerOf2I(HMod* instr);
- LInstruction* DoModByConstI(HMod* instr);
LInstruction* DoModI(HMod* instr);
LInstruction* DoFlooringDivByPowerOf2I(HMathFloorOfDiv* instr);
LInstruction* DoFlooringDivByConstI(HMathFloorOfDiv* instr);
« no previous file with comments | « src/a64/macro-assembler-a64.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698